Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

2015-06-17 Thread Alan Bateman
On 15/06/2015 22:58, Roger Riggs wrote: Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the same technique used by Hotspot in src/os/windows/vm/os_windows.cpp. The Windows link of CoreLibraries.gmk

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

2015-06-17 Thread Erik Joelsson
Hello Roger, Build change looks fine to me. /Erik On 2015-06-15 23:58, Roger Riggs wrote: Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the same technique used by Hotspot in

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

2015-06-17 Thread Roger Riggs
Hi Alan, Would there be any concerns about backporting to JDK 8? On 6/17/2015 7:32 AM, Alan Bateman wrote: On 15/06/2015 22:58, Roger Riggs wrote: Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

2015-06-17 Thread Alan Bateman
On 17/06/2015 14:49, Roger Riggs wrote: Hi Alan, Would there be any concerns about backporting to JDK 8? I don't think so but it will require the jdk8u maintainers to approve. The new helper APIs https://msdn.microsoft.com/en-us/library/windows/desktop/ms724451%28v=vs.85%29.aspx only

RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

2015-06-15 Thread Roger Riggs
Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the same technique used by Hotspot in src/os/windows/vm/os_windows.cpp. The Windows link of CoreLibraries.gmk includes version.lib/dll. The behavior