Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

2013-03-28 Thread Mandy Chung
Looks good to me. Mandy On 3/18/13 10:48 PM, Mike Duigou wrote: A two small changes to review: If approved I will commit to TL (or someone else can commit to build for me) Mike JDK-8010267 : Add test-clean for cleaning of testoutput directory from output directory. diff --git a/common/make

Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

2013-03-28 Thread Tim Bell
Mike - Looks good to me. Tim On 03/28/13 01:11, Erik Joelsson wrote: Both of these look good to me, but you still need a jdk8 reviewer. /Erik On 2013-03-27 17:27, Mike Duigou wrote: I still need a review for both of these changes. Mike On Mar 18 2013, at 22:48 , Mike Duigou wrote: A two

Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

2013-03-28 Thread Erik Joelsson
Both of these look good to me, but you still need a jdk8 reviewer. /Erik On 2013-03-27 17:27, Mike Duigou wrote: I still need a review for both of these changes. Mike On Mar 18 2013, at 22:48 , Mike Duigou wrote: A two small changes to review: If approved I will commit to TL (or someone el

Re: RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

2013-03-27 Thread Mike Duigou
I still need a review for both of these changes. Mike On Mar 18 2013, at 22:48 , Mike Duigou wrote: > A two small changes to review: > > If approved I will commit to TL (or someone else can commit to build for me) > > Mike > > JDK-8010267 : Add test-clean for cleaning of testoutput directory

RFR JDK-8010267 & JDK-8010268 : Makefile maintenance for test targets

2013-03-18 Thread Mike Duigou
A two small changes to review: If approved I will commit to TL (or someone else can commit to build for me) Mike JDK-8010267 : Add test-clean for cleaning of testoutput directory from output directory. diff --git a/common/makefiles/Main.gmk b/common/makefiles/Main.gmk --- a/common/makefiles/M