Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Chris Hegarty
On 14 Oct 2014, at 15:03, Pavel Rappo pavel.ra...@oracle.com wrote: OK, so what I will do for now is I exclude these 4 files and push without them. I'll create a new issue to add them later. That sounds like a fine plan. This issue has already gone on for long enough, and I don’t think that

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Daniel Fuchs
On 14/10/14 16:09, Chris Hegarty wrote: On 14 Oct 2014, at 15:03, Pavel Rappo pavel.ra...@oracle.com wrote: OK, so what I will do for now is I exclude these 4 files and push without them. I'll create a new issue to add them later. That sounds like a fine plan. This issue has already gone on

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Pavel Rappo
Thanks a lot! -Pavel On 14 Oct 2014, at 15:33, Chris Hegarty chris.hega...@oracle.com wrote: META-INF files in the webrev, two of which are in the wrong location. They are directly under 'META-INF’, where they should all be under ‘META-INF/services’. This is just a note for Pavel, when he

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Chris Hegarty
On 14 Oct 2014, at 15:15, Daniel Fuchs daniel.fu...@oracle.com wrote: On 14/10/14 16:09, Chris Hegarty wrote: On 14 Oct 2014, at 15:03, Pavel Rappo pavel.ra...@oracle.com wrote: OK, so what I will do for now is I exclude these 4 files and push without them. I'll create a new issue to add