Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-23 Thread Alan Bateman
On 22/01/2017 19:27, Xueming Shen wrote: The assumption is the remove of the version tag can help us to easily get the diffs from the webrev directly in future upgrade. Here is the webrev with the diff by listing old and new files in a webrev list file. http://cr.openjdk.java.net/~sherman/8

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-23 Thread Erik Joelsson
Build changes look good. Thanks! /Erik On 2017-01-21 21:41, Xueming Shen wrote: Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Thanks, Sherman On 1/21/17, 12:30 AM, Erik Joelsson wrote: Hello, Build changes

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-22 Thread Xueming Shen
On 1/22/17, 9:46 AM, Alan Bateman wrote: On 21/01/2017 20:41, Xueming Shen wrote: Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Switching to zlib looks good although it's impossible to see the changes in this

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-22 Thread Alan Bateman
On 21/01/2017 20:41, Xueming Shen wrote: Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Switching to zlib looks good although it's impossible to see the changes in this webrev because all the files show up as ne

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Xueming Shen
Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Thanks, Sherman On 1/21/17, 12:30 AM, Erik Joelsson wrote: Hello, Build changes look ok. I'm in favor with dropping the version number from the path. There is a RE

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Alan Bateman
On 20/01/2017 20:15, Xueming Shen wrote: Hi, Please review the change to upgrade the zlib bundled in jdk repo from v1.2.8 to v1.2.11. jdk9 by default has been configured to build by using the native/ platform/os's zlib on all non-windows platform [1] So the change will only have effect on th

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Thomas Stüfe
Hi, On Sat, Jan 21, 2017 at 9:30 AM, Erik Joelsson wrote: > Hello, > > Build changes look ok. I'm in favor with dropping the version number from > the path. There is a README that clearly states the current version and we > don't keep multiple versions in the repo anyway. Doing so would also red

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Erik Joelsson
Hello, Build changes look ok. I'm in favor with dropping the version number from the path. There is a README that clearly states the current version and we don't keep multiple versions in the repo anyway. Doing so would also reduce repo meta data bloat from doing these upgrades in the future

RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-20 Thread Xueming Shen
Hi, Please review the change to upgrade the zlib bundled in jdk repo from v1.2.8 to v1.2.11. jdk9 by default has been configured to build by using the native/ platform/os's zlib on all non-windows platform [1] So the change will only have effect on the Windows' binaries. issue: https://bugs.o