Re: RFRF: 8043936 Drop HPROF as demo, keep as HPROF agent shipped with JDK

2014-08-25 Thread Alan Bateman
On 25/08/2014 15:38, Staffan Larsen wrote: On 25 aug 2014, at 16:15, Alan Bateman wrote: : Having the README and manual in the same directory is probably okay as it has always lived in the same directory as the source code. One thing is check is the contents of manual.html as there is at le

Re: RFRF: 8043936 Drop HPROF as demo, keep as HPROF agent shipped with JDK

2014-08-25 Thread Staffan Larsen
On 25 aug 2014, at 16:15, Alan Bateman wrote: > On 25/08/2014 14:35, Staffan Larsen wrote: >> Please review the following change to remove hprof as part of the demo >> package. Instead, the source code has been moved to the jdk.hprof.agent >> module. >> >> bug: https://bugs.openjdk.java.net/b

Re: RFRF: 8043936 Drop HPROF as demo, keep as HPROF agent shipped with JDK

2014-08-25 Thread Erik Joelsson
Build changes look ok to me. /Erik On 2014-08-25 15:35, Staffan Larsen wrote: Please review the following change to remove hprof as part of the demo package. Instead, the source code has been moved to the jdk.hprof.agent module. bug: https://bugs.openjdk.java.net/browse/JDK-8043936 webrev: ht

Re: RFRF: 8043936 Drop HPROF as demo, keep as HPROF agent shipped with JDK

2014-08-25 Thread Alan Bateman
On 25/08/2014 14:35, Staffan Larsen wrote: Please review the following change to remove hprof as part of the demo package. Instead, the source code has been moved to the jdk.hprof.agent module. bug: https://bugs.openjdk.java.net/browse/JDK-8043936 webrev: http://cr.openjdk.java.net/~sla/8043936

RFRF: 8043936 Drop HPROF as demo, keep as HPROF agent shipped with JDK

2014-08-25 Thread Staffan Larsen
Please review the following change to remove hprof as part of the demo package. Instead, the source code has been moved to the jdk.hprof.agent module. bug: https://bugs.openjdk.java.net/browse/JDK-8043936 webrev: http://cr.openjdk.java.net/~sla/8043936/webrev.00/ Thanks, /Staffan