Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread David Holmes
On 21/08/2017 7:23 PM, John Paul Adrian Glaubitz wrote: On 08/18/2017 01:37 PM, John Paul Adrian Glaubitz wrote: This is my very first issue opened in the Java Bug System, so please bear with me if there are any issues with my report. FWIW, I still need to understand how to push the patch to

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread John Paul Adrian Glaubitz
On 08/21/2017 03:11 PM, Erik Joelsson wrote: I will do it, for both of your changes. Ok. And I was told to remind my sponsor to regenerate the generated_configure.sh after pushing the changes to platform.m4. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer -

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread Erik Joelsson
Ah, I was just about to push to jdk10/jdk10, thanks! /Erik On 2017-08-21 15:12, David Holmes wrote: Hi Erik, Also note that these changes should go to jdk10/hs forest so that they will be in the safe place as Adrian's other hotspot patches as they come in. David On 21/08/2017 11:09 PM,

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread David Holmes
Hi Erik, Also note that these changes should go to jdk10/hs forest so that they will be in the safe place as Adrian's other hotspot patches as they come in. David On 21/08/2017 11:09 PM, John Paul Adrian Glaubitz wrote: Hi Eric! On 08/21/2017 03:08 PM, Erik Joelsson wrote: Your change

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread Erik Joelsson
I will do it, for both of your changes. /Erik On 2017-08-21 15:09, John Paul Adrian Glaubitz wrote: Hi Eric! On 08/21/2017 03:08 PM, Erik Joelsson wrote: Your change looks ok. I assume you will also need a sponsor? Yes, I think so. I assume I don't any push rights ;). Adrian

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread John Paul Adrian Glaubitz
Hi Eric! On 08/21/2017 03:08 PM, Erik Joelsson wrote: Your change looks ok. I assume you will also need a sponsor? Yes, I think so. I assume I don't any push rights ;). Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread Erik Joelsson
Your change looks ok. I assume you will also need a sponsor? /Erik On 2017-08-21 11:23, John Paul Adrian Glaubitz wrote: On 08/18/2017 01:37 PM, John Paul Adrian Glaubitz wrote: This is my very first issue opened in the Java Bug System, so please bear with me if there are any issues with my

Re: [RFR]: 8186433: Compiler flag -arch=sparc should not be passed on linux-sparc

2017-08-21 Thread John Paul Adrian Glaubitz
On 08/18/2017 01:37 PM, John Paul Adrian Glaubitz wrote: This is my very first issue opened in the Java Bug System, so please bear with me if there are any issues with my report. FWIW, I still need to understand how to push the patch to the webreview system. Here's the webrev for this one [1].