I think that looks fine.
-kto
On Jan 18, 2012, at 9:29 PM, David Holmes wrote:
> FYI here is proposed webrev:
>
> http://cr.openjdk.java.net/~dholmes/7130909/webrev/
>
> CR 7130909 was filed.
>
> David
>
> On 19/01/2012 1:30 PM, David Holmes wrote:
>> Hi Kelly,
>>
>> On 19/01/2012 2:22 AM,
FYI here is proposed webrev:
http://cr.openjdk.java.net/~dholmes/7130909/webrev/
CR 7130909 was filed.
David
On 19/01/2012 1:30 PM, David Holmes wrote:
Hi Kelly,
On 19/01/2012 2:22 AM, Kelly O'Hair wrote:
On Jan 17, 2012, at 7:17 PM, David Holmes wrote:
On 18/01/2012 7:07 AM, Kelly O'Hai
Hi Kelly,
On 19/01/2012 2:22 AM, Kelly O'Hair wrote:
On Jan 17, 2012, at 7:17 PM, David Holmes wrote:
On 18/01/2012 7:07 AM, Kelly O'Hair wrote:
Generally, I have no objection to this change.
But instead of setting it to NO_SUCH_PATH, I would not set it at all, and avoid
the $(shell) to se
On Jan 17, 2012, at 7:17 PM, David Holmes wrote:
> On 18/01/2012 7:07 AM, Kelly O'Hair wrote:
>> Generally, I have no objection to this change.
>>
>> But instead of setting it to NO_SUCH_PATH, I would not set it at all, and
>> avoid the $(shell) to see if it
>> exists completely. Just don't se
On 18/01/2012 7:07 AM, Kelly O'Hair wrote:
Generally, I have no objection to this change.
But instead of setting it to NO_SUCH_PATH, I would not set it at all, and avoid
the $(shell) to see if it
exists completely. Just don't set CUSTOM_MAKE_DIR if it does not exist.
Then you don't need the HA
Generally, I have no objection to this change.
But instead of setting it to NO_SUCH_PATH, I would not set it at all, and avoid
the $(shell) to see if it
exists completely. Just don't set CUSTOM_MAKE_DIR if it does not exist.
Then you don't need the HAS_CUSTOM_MAKE, it can just be ifdef CUSTOM_MA
On 16/01/2012 8:45 PM, Dmitry Samersoff wrote:
I'm not sure I catch you idea correct.
May be we can just create a directory, something like make.d
and then do
for i in make.d/*
do
-include ...
done
No that's not what I'm trying to do. Take a look at where the existing
Defs-embedded.gmk an
David,
I'm not sure I catch you idea correct.
May be we can just create a directory, something like make.d
and then do
for i in make.d/*
do
-include ...
done
-Dmitry
On 2012-01-16 09:01, David Holmes wrote:
> Presently the build system contains some files, and directives involving
> those
