Re: GHAs and precompiled headers

2022-01-24 Thread Thomas Stüfe
On Mon, Jan 24, 2022 at 10:31 AM Aleksey Shipilev wrote: > On 1/24/22 10:26 AM, Thomas Stüfe wrote: > > > > > > On Mon, Jan 24, 2022 at 10:15 AM Aleksey Shipilev > wrote: > > > > On 1/24/22 8:43 AM, Thomas Stüfe wrote: > > > We generally build without --disable-

Re: GHAs and precompiled headers

2022-01-24 Thread Aleksey Shipilev
On 1/24/22 10:26 AM, Thomas Stüfe wrote: On Mon, Jan 24, 2022 at 10:15 AM Aleksey Shipilev mailto:sh...@redhat.com>> wrote: On 1/24/22 8:43 AM, Thomas Stüfe wrote: > We generally build without --disable-precompiled-headers in GHAs, which > hides errors from missing includes. Sinc

Re: GHAs and precompiled headers

2022-01-24 Thread Thomas Stüfe
On Mon, Jan 24, 2022 at 10:15 AM Aleksey Shipilev wrote: > On 1/24/22 8:43 AM, Thomas Stüfe wrote: > > We generally build without --disable-precompiled-headers in GHAs, which > > hides errors from missing includes. Since GHAs are very useful to test > > builds on side platforms, would it not make

Re: GHAs and precompiled headers

2022-01-24 Thread Aleksey Shipilev
On 1/24/22 8:43 AM, Thomas Stüfe wrote: We generally build without --disable-precompiled-headers in GHAs, which hides errors from missing includes. Since GHAs are very useful to test builds on side platforms, would it not make sense to build without precompiled headers? Or is that too costly? B