Re: RFR: JDK-8179022 Add serialization spec as markdown

Hi Magnus, Looks good, I checked the previous and new html content and found no significant differences. There are some content improvements that should be made but that's a separate task. Thanks, Roger On 4/20/2017 2:51 PM, Roger Riggs wrote: Hi Magnus, How did you verify that the result

Re: RFR: JDK-8179022 Add serialization spec as markdown

> On Apr 20, 2017, at 11:47 AM, Magnus Ihse Bursie wrote: > > http://cr.openjdk.java.net/~ihse/JDK-8179022-add-markdown-serialization-spec/webrev.02 A passing comment. Copyright header is missing in make/devkit/createPandocBundle.sh Mandy

Re: RFR: JDK-8179022 Add serialization spec as markdown

Hi Magnus, How did you verify that the result was the same as the previous specification? It would have been good to separate the content changes from the other parts so they could be properly reviewed. The proposed markdown source does not favorably easily with the spec as I worked on it a co

Re: RFR: JDK-8179022 Add serialization spec as markdown

On 2017-04-20 15:59, Alan Bateman wrote: On 20/04/2017 14:49, Magnus Ihse Bursie wrote: Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html using pandoc. The Java serialization spec is

Re: RFR: JDK-8179022 Add serialization spec as markdown

The build changes look good to me. I can't comment on the actual .md files. /Erik On 2017-04-20 15:49, Magnus Ihse Bursie wrote: Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html usin

Re: RFR: JDK-8179022 Add serialization spec as markdown

On 20/04/2017 14:49, Magnus Ihse Bursie wrote: Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html using pandoc. The Java serialization spec is added in markdown format as a proof of con