Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-28 Thread Maurizio Cimadamore
I have been bitten by this change - not something too difficult to handle, but I think it can be confusing - e.g. if you run 'make reconfigure' the old config name will be preserved, but if you run 'sh configure' from scratch you will have two configuration sitting beside each other and any mak

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Erik Joelsson
Looks good. /Erik On 2018-09-20 11:42, Magnus Ihse Bursie wrote: On 2018-09-20 19:47, Erik Joelsson wrote: On 2018-09-20 10:24, Magnus Ihse Bursie wrote: On 2018-09-20 18:59, Aleksey Shipilev wrote: On 09/20/2018 06:48 PM, Magnus Ihse Bursie wrote: A long time ago, we supported differen

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Magnus Ihse Bursie
On 2018-09-20 19:47, Erik Joelsson wrote: On 2018-09-20 10:24, Magnus Ihse Bursie wrote: On 2018-09-20 18:59, Aleksey Shipilev wrote: On 09/20/2018 06:48 PM, Magnus Ihse Bursie wrote: A long time ago, we supported different "variants" of the JDK build, like "normal" and "embedded". The --

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Erik Joelsson
On 2018-09-20 11:35, Aleksey Shipilev wrote: I guess the question is how much variability is there in day-to-day builds. As the guy who builds lots of different configurations, I see great simplicity in maintaining current static label that captures most of the usual variability. For example,

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Aleksey Shipilev
On 09/20/2018 07:24 PM, Magnus Ihse Bursie wrote: > Currently the default format looks like this: > "linux-x86_64-normal-server-release", that is > . The selection of these > configuration > parameters feels a bit arbitrary. Some examples of other parameters we could > have included, but > d

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Erik Joelsson
On 2018-09-20 10:24, Magnus Ihse Bursie wrote: On 2018-09-20 18:59, Aleksey Shipilev wrote: On 09/20/2018 06:48 PM, Magnus Ihse Bursie wrote: A long time ago, we supported different "variants" of the JDK build, like "normal" and "embedded". The --with-jdk-variant and associated machinery has

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Magnus Ihse Bursie
On 2018-09-20 18:59, Aleksey Shipilev wrote: On 09/20/2018 06:48 PM, Magnus Ihse Bursie wrote: A long time ago, we supported different "variants" of the JDK build, like "normal" and "embedded". The --with-jdk-variant and associated machinery has been kept in place, even though it's not doin

Re: RFR: JDK-8210962 Deprecate jdk-variant

2018-09-20 Thread Aleksey Shipilev
On 09/20/2018 06:48 PM, Magnus Ihse Bursie wrote: > A long time ago, we supported different "variants" of the JDK build, like > "normal" and "embedded". > The --with-jdk-variant and associated machinery has been kept in place, even > though it's not doing > anyting. Time to remove it. > > I chos