Hi Alexander,
Ok, thanks
Note: code reviews of code going into the sandbox is not a substitute
for code review when it is to be pushed to jdk/jdk.
(The sandbox has much more informal rules for commits that are branch
specific.)
Roger
On 02/19/2019 10:44 PM, Alexander Matveev wrote:
Hi Roge
Hi Roger,
Some deleted files are actually deleted files, since I did code cleanup
as well.
Added files contain code from splitting original source files. This was
needed to re-arrange code.
Not sure how to log with hg file split.
Also, we already moved files without keeping history, since we
Hi Alexander,
Some files appear to be moved with hg, but others are copied and deleted.
Please use hg mv to retain the continuity of the history.
Thanks, Roger
On 02/15/2019 10:03 PM, Alexander Matveev wrote:
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8212091/webrev.01/
Moved all files
> 16 feb. 2019 kl. 04:03 skrev Alexander Matveev :
>
> Hi Magnus,
>
> http://cr.openjdk.java.net/~almatvee/8212091/webrev.01/
>
> Moved all files from "posix" to "unix" folder and reverted
> Lib-jdk.jpackage.gmk changes.
> Webrev updated with files moved, instead of add/remove.
Thank you!
T
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8212091/webrev.01/
Moved all files from "posix" to "unix" folder and reverted
Lib-jdk.jpackage.gmk changes.
Webrev updated with files moved, instead of add/remove.
Thanks,
Alexander
On 2/14/2019 11:44 PM, Magnus Ihse Bursie wrote:
On 2019-02
On 2019-02-15 04:31, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Moved native code under platform specific folder.
- Removed most usage on #ifdefs for WINDOWS, LINUX
