Looks good.
Cheers,
Mikael
> On Apr 9, 2020, at 9:56 AM, Erik Joelsson wrote:
>
> When building with VS2019, there is a new runtime library,
> vcruntime140_1.dll, that we need to bundle along with the others. This patch
> sets this up all through the build.
>
> Bug: https://bugs.openjdk.ja
On 2020-04-14 15:13, Erik Joelsson wrote:
The intention is that the new dll should only be required for
TOOLCHAIN_VERSION that define it, just like MSVP_DLL which was
introduced in VS2012.
I will verify again that this is actually true.
My worry is with this piece of code in toolchain_window
The intention is that the new dll should only be required for
TOOLCHAIN_VERSION that define it, just like MSVP_DLL which was
introduced in VS2012.
I will verify again that this is actually true.
/Erik
On 2020-04-14 05:59, Magnus Ihse Bursie wrote:
Maybe I'm missing something here, but will th
Maybe I'm missing something here, but will this not break for VS
versions before 2019 that does not have vcruntime140_1.dll?
/Magnus
On 2020-04-09 18:56, Erik Joelsson wrote:
When building with VS2019, there is a new runtime library,
vcruntime140_1.dll, that we need to bundle along with the ot
Erik:
Looks good.
When building with VS2019, there is a new runtime library,
vcruntime140_1.dll, that we need to bundle along with the others. This
patch sets this up all through the build.
Bug: https://bugs.openjdk.java.net/browse/JDK-8242468
Webrev: http://cr.openjdk.java.net/~erikj/82424
