Re: RFR: JDK-8244210: The javac server is never used

2020-05-04 Thread Magnus Ihse Bursie
On 2020-04-30 21:10, Erik Joelsson wrote: Hello, A minor mistake in JDK-8244036 is causing the javac server to never be used, which is rather severly increasing build times. Before that change, the global variable ENABLE_SJAVAC was used to determine if the server should be activated. After t

Re: RFR: JDK-8244210: The javac server is never used

2020-04-30 Thread Florian Weimer
* Erik Joelsson: > A minor mistake in JDK-8244036 is causing the javac server to never be > used, which is rather severly increasing build times. > > Before that change, the global variable ENABLE_SJAVAC was used to > determine if the server should be activated. After the change, the > global v

Re: RFR: JDK-8244210: The javac server is never used

2020-04-30 Thread Claes Redestad
Looks good, Erik, Thanks! /Claes On 2020-04-30 21:10, Erik Joelsson wrote: Hello, A minor mistake in JDK-8244036 is causing the javac server to never be used, which is rather severly increasing build times. Before that change, the global variable ENABLE_SJAVAC was used to determine if the

Re: RFR: JDK-8244210: The javac server is never used

2020-04-30 Thread Tim Bell
Erik: Looks good. Tim Hello, A minor mistake in JDK-8244036 is causing the javac server to never be used, which is rather severly increasing build times. Before that change, the global variable ENABLE_SJAVAC was used to determine if the server should be activated. After the change, the g