Re: Removal of the old build system, partial and preliminary review (part 2)

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-01 14:43, Magnus Ihse Bursie wrote: And here is the WebRev: http://cr.openjdk.java.net/~ihse/remove-old-build-part-2/webrev.01 It turned out that this webrev suffered from the same problems as the review in part 3, only it was not as obvious. I have created a new webrev, which now

Re: Removal of the old build system, partial and preliminary review (part 2)

2013-11-06 Thread Bradford Wetmore
I've looked at: jdk/makefiles/CreateSecurityJars.gmk jdk/make/data/cryptopolicy My only comment is the non-CamelCase style names (swingbeaninfo/cryptopolicy/characterdata/charsetmapping/etc), but I guess I can live with it. Brad On 11/1/2013 6:43 AM, Magnus Ihse Bursie wrote: Here is p

Re: Removal of the old build system, partial and preliminary review (part 2)

2013-11-04 Thread Erik Joelsson
Looks correct, but needs to be compared on all platforms. /Erik On 2013-11-01 14:43, Magnus Ihse Bursie wrote: Here is part 2 of the old build system removal. This review is based against the previous part, i.e. where the lion's share of the old make files had been removed. What remained wa

Re: Removal of the old build system, partial and preliminary review (part 2)

2013-11-02 Thread Alan Bateman
On 01/11/2013 13:43, Magnus Ihse Bursie wrote: * Move files actually used from make/tools/CharsetMapping to make/data/charsetmapping. Just on this one, webrev is reporting lines changed in several of the mapping files but it's not clear why. I assume you just did a "hg mv -f". In any case, t

Removal of the old build system, partial and preliminary review (part 2)

2013-11-01 Thread Magnus Ihse Bursie
Here is part 2 of the old build system removal. This review is based against the previous part, i.e. where the lion's share of the old make files had been removed. What remained was a handful or two of different types of files, scattered all around. I have checked each file and/or directory