Re: Request for Review: Support build-infra output directory in langtools test

2012-10-29 Thread Magnus Ihse Bursie
On 2012-10-27 00:27, Kelly O'Hair wrote: The only important thing for integration with build-infra is that the langtools test makefile gets a customizable output directory, so it is not hard-coded to the old output directory. Fair enough, but let's see if we can integrate that change into

Re: Request for Review: Support build-infra output directory in langtools test

2012-10-26 Thread Magnus Ihse Bursie
On 2012-10-26 02:22, Jonathan Gibbons wrote: I note that there are some notes on the OpenJDK website about running tests. See here: http://openjdk.java.net/jtreg/#makefile In particular, it includes this text: When using these targets, it is recommended to set the following variables,

Re: Request for Review: Support build-infra output directory in langtools test

2012-10-26 Thread Kelly O'Hair
On Oct 25, 2012, at 9:39 PM, Magnus Ihse Bursie wrote: As I said, the name ALT_OUTPUTDIR is already used in jdk/test/Makefile. That is the reason I used it. Of course it could be called anything, but if it is not called the same thing across repos, we get a hard time for no good reason. I

Request for Review: Support build-infra output directory in langtools test

2012-10-25 Thread Magnus Ihse Bursie
There are several similarities between jdk/test/Makefile and langtools/test/Makefile. This makes it possible to run tests from either one in build-infra (the new build system) by using the target test. In jdk/test/Makefile there is a test for an external variable ALT_OUTPUTDIR, which directs

Re: Request for Review: Support build-infra output directory in langtools test

2012-10-25 Thread Jonathan Gibbons
I note that there are some notes on the OpenJDK website about running tests. See here: http://openjdk.java.net/jtreg/#makefile In particular, it includes this text: When using these targets, it is recommended to set the following variables, either as environment variables or on the make

Re: Request for Review: Support build-infra output directory in langtools test

2012-10-25 Thread Magnus Ihse Bursie
As I said, the name ALT_OUTPUTDIR is already used in jdk/test/Makefile. That is the reason I used it. Of course it could be called anything, but if it is not called the same thing across repos, we get a hard time for no good reason. The only important thing for integration with build-infra is