Looks good to me though I'm not a jdk7 reviewer.
/Erik
On 2013-07-12 07:22, Tim Bell wrote:
David, Erik -
Thanks for the feedback:
Does this also need to check for OPENJDK in case you are doing an
OPENJDK build with a full forest present? Or is this logic already
by-passed for OPENJDK
On 12/07/2013 4:57 PM, Erik Joelsson wrote:
Looks good to me though I'm not a jdk7 reviewer.
I am :)
Tim I think this is okay. Certainly it only makes sense to build install
bundles if building install.
I just wonder why building install bundles has to appear at this
top-level anyway. But
On 7/12/13 8:57 AM, Erik Joelsson wrote:
Looks good to me though I'm not a jdk7 reviewer.
Looks good to me, too. Local OpenJDK build on OS X and an OpenJDK linux build
on JPRT both passed.
Please send in a fresh phase 2 approval request to the jdk7u-dev list.
cheers,
dalibor topic
/Erik
On 07/12/13 12:02 AM, David Holmes wrote:
I am :)
Tim I think this is okay. Certainly it only makes sense to build
install bundles if building install.
Good. Thanks for the review.
I just wonder why building install bundles has to appear at this
top-level anyway. But that's a different
On 2013-07-11 07:30, David Holmes wrote:
Tim,
On 11/07/2013 6:47 AM, Tim Bell wrote:
On 07/10/13 12:37 PM, Tim Bell wrote:
Hi Kelly
How did BUILD_INSTALL ever become true on an OpenJDK build?
From the 'generic_debug_build' rule in the top level 7update
Makefile [1]
generic_debug_build:
David, Erik -
Thanks for the feedback:
Does this also need to check for OPENJDK in case you are doing an
OPENJDK build with a full forest present? Or is this logic already
by-passed for OPENJDK builds?
David
Setting OPENJDK=true on the command line will force
BUILD_INSTALL=false, even
On 7/10/2013 12:37 PM, Tim Bell wrote:
Hi Kelly
How did BUILD_INSTALL ever become true on an OpenJDK build?
There is only one place that the build itself sets BUILD_INSTALL to true
and that's upon detection of install/make/Makefile, in
make/Defs-internal.gmk:
If you have a full forest
On 07/10/13 12:37 PM, Tim Bell wrote:
Hi Kelly
How did BUILD_INSTALL ever become true on an OpenJDK build?
From the 'generic_debug_build' rule in the top level 7update Makefile [1]
generic_debug_build:
$(MAKE) \
ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \
Tim,
On 11/07/2013 6:47 AM, Tim Bell wrote:
On 07/10/13 12:37 PM, Tim Bell wrote:
Hi Kelly
How did BUILD_INSTALL ever become true on an OpenJDK build?
From the 'generic_debug_build' rule in the top level 7update Makefile [1]
generic_debug_build:
$(MAKE) \
All-
My fix for 8007815 [1] did not handle the case of an OpenJDK build that
does not have the closed source trees. If a user tries to build that
far, the build will fail with cd: can't cd to
./install/make/installer/binaries/linux
This is a request for review and approval to fix 8012366
How did BUILD_INSTALL ever become true on an OpenJDK build?
-kto
On Jul 8, 2013, at 12:03 PM, Tim Bell wrote:
All-
My fix for 8007815 [1] did not handle the case of an OpenJDK build that does
not have the closed source trees. If a user tries to build that far, the
build will fail with
11 matches
Mail list logo
