New webrev for this:
http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/
I changed the sed to only remove the -R argument and made it conditional
on cross compilation.
A bit of background on this. The X_LIBS variable is created by autoconf
by calling some special macros to locate
Okay. I can't attest to the accuracy of the sed command but I agree with
the intent :) Though I'm not sure there still exists any place where we
use X_LIBS if cross-compiling.
Thanks,
David
On 22/01/2013 8:18 PM, Erik Joelsson wrote:
New webrev for this:
Hi Erik:
New webrev for this:
http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/
I changed the sed to only remove the -R argument and made it
conditional on cross compilation.
Looks good. Thanks for the background!
Tim
A bit of background on this. The X_LIBS variable is created
8003958 fixes this for sizer generation yes, but there is also one
library in CompileNativeLibraries that has X_LIBS on the link line. But
I suppose we shouldn't fix it unless there is a problem with it.
/Erik
On 2013-01-09 03:56, David Holmes wrote:
On 9/01/2013 5:56 AM, Kelly O'Hair wrote:
Hi Erik:
Filter away -R flags from X_LIBS variable in configure.
http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/
common/autoconf/libraries.m4:
143 X_LIBS=`$ECHO $X_LIBS | $SED 's/-R.*//g'`
If I am reading this correctly, sed will delete everything from -R to
end of line. Is
I need more info on this, what is X_LIBS for, and why remove ALL -R options.
I always considered the -R options to be LD options, not library specifications
really.
The -L and -l options are library specifications, but -R is just a path that
gets baked into the .so
for runtime access to the
On 9/01/2013 5:56 AM, Kelly O'Hair wrote:
I need more info on this, what is X_LIBS for, and why remove ALL -R options.
IIRC Fredrik added this to deal with some binary difference detected on
OSX. I don't know what these variables actually contain
I always considered the -R options to be LD
