Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-14 Thread Kelly O'Hair
Ok from me. -kto On Jan 14, 2013, at 5:24 AM, Erik Joelsson wrote: > This didn't quite work as I expected. Found the issue in needing to include > SPEC before Jprt.gmk so that variables from SPEC would be available in > Jprt.gmk at parse time. > > http://cr.openjdk.java.net/~erikj/8006100/web

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-14 Thread Alan Bateman
On 14/01/2013 13:24, Erik Joelsson wrote: This didn't quite work as I expected. Found the issue in needing to include SPEC before Jprt.gmk so that variables from SPEC would be available in Jprt.gmk at parse time. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ /Erik Thanks Erik, I'v

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-14 Thread Tim Bell
Erik: This didn't quite work as I expected. Found the issue in needing to include SPEC before Jprt.gmk so that variables from SPEC would be available in Jprt.gmk at parse time. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ Looks good. Tim /Erik On 2013-01-11 17:25, Erik Joe

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-14 Thread Erik Joelsson
This didn't quite work as I expected. Found the issue in needing to include SPEC before Jprt.gmk so that variables from SPEC would be available in Jprt.gmk at parse time. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ /Erik On 2013-01-11 17:25, Erik Joelsson wrote: This fixes the b

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-11 Thread Kelly O'Hair
Looks good. -kto On Jan 11, 2013, at 8:25 AM, Erik Joelsson wrote: > This fixes the bundles target for jprt so that overlay images are bundled up > for solaris 64bit. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ > > Even if several people would like to do away with the overla

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-11 Thread Tim Bell
Erik: This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Looks good. Even if several people would like to do away with the overlay images, that change should be separate to switching to b

Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-11 Thread Erik Joelsson
This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Even if several people would like to do away with the overlay images, that change should be separate to switching to build-infra. /Erik