Re: Review Request: JDK-8173858: Rename libmanagement_rmi to libmanagement_agent

2017-02-03 Thread Daniel Fuchs
+1 libmanagement_agent is indeed a better name :-) best regards, -- daniel On 02/02/17 22:27, Mandy Chung wrote: libmanagement_agent should be the proper library name for jdk.management.agent. It was an oversight with the current name. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/81738

Re: Review Request: JDK-8173858: Rename libmanagement_rmi to libmanagement_agent

2017-02-03 Thread Erik Joelsson
Looks good. /Erik On 2017-02-02 23:27, Mandy Chung wrote: libmanagement_agent should be the proper library name for jdk.management.agent. It was an oversight with the current name. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173858/webrev.00/ This patch also takes out the qualified ex

Re: Review Request: JDK-8173858: Rename libmanagement_rmi to libmanagement_agent

2017-02-02 Thread Alan Bateman
On 02/02/2017 22:27, Mandy Chung wrote: libmanagement_agent should be the proper library name for jdk.management.agent. It was an oversight with the current name. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173858/webrev.00/ This patch also takes out the qualified exports of java.base/j

Re: Review Request: JDK-8173858: Rename libmanagement_rmi to libmanagement_agent

2017-02-02 Thread Mandy Chung
> On Feb 2, 2017, at 3:58 PM, David Holmes wrote: > > Hi Mandy, > > Looks reasonable. > > No tests that need changing? > No since it’s just the shared library name change. The shared library provides the native method implementation for jdk.internal.agent.FileSystem (no change there) Man

Re: Review Request: JDK-8173858: Rename libmanagement_rmi to libmanagement_agent

2017-02-02 Thread David Holmes
Hi Mandy, Looks reasonable. No tests that need changing? Thanks, David On 3/02/2017 8:27 AM, Mandy Chung wrote: libmanagement_agent should be the proper library name for jdk.management.agent. It was an oversight with the current name. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173858

Review Request: JDK-8173858: Rename libmanagement_rmi to libmanagement_agent

2017-02-02 Thread Mandy Chung
libmanagement_agent should be the proper library name for jdk.management.agent. It was an oversight with the current name. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173858/webrev.00/ This patch also takes out the qualified exports of java.base/jdk.internal.vm to java.management which i