Re: Review Request JDK-8205627: Replace hardcoded spec version value in build.tools.ExtLink taglet

2018-06-25 Thread Erik Joelsson
Looks good to me. /Erik On 2018-06-25 14:09, mandy chung wrote: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00 ExtLink taglet generates an external link to a JDK documentation page of a specific release.  This patch replaces the hardcoded value with the value of a

Re: Review Request JDK-8205627: Replace hardcoded spec version value in build.tools.ExtLink taglet

2018-06-25 Thread Jonathan Gibbons
+1 -- Jon On 06/25/2018 02:09 PM, mandy chung wrote: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00 ExtLink taglet generates an external link to a JDK documentation page of a specific release. This patch replaces the hardcoded value with the value of a system property

Review Request JDK-8205627: Replace hardcoded spec version value in build.tools.ExtLink taglet

2018-06-25 Thread mandy chung
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00 ExtLink taglet generates an external link to a JDK documentation page of a specific release. This patch replaces the hardcoded value with the value of a system property "extlink.spec.version" passed to the javadoc at runtime.