Re: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Kelly O'Hair
Anthony Petrov wrote: On 4/23/2009 10:40 PM Kelly O'Hair wrote: As I emailed earlier, I'd be ok with this change but only if RE (Xiomara) was ok with it, and we made sure everyone was warned well in advance. Thanks! Also, the change is incomplete because the README-builds.html file probably

Re: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Anthony Petrov
On 4/23/2009 10:40 PM Kelly O'Hair wrote: As I emailed earlier, I'd be ok with this change but only if RE (Xiomara) was ok with it, and we made sure everyone was warned well in advance. Thanks! Also, the change is incomplete because the README-builds.html file probably would need to change too

Re: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Anthony Petrov
On 4/23/2009 10:31 PM xiomara.jayas...@sun.com wrote: We do set ALT_BOOTDIR all the time. From Kelly: Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted by this change, but I bet quite a few people rely on this c:/

Re: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Kelly O'Hair
As I emailed earlier, I'd be ok with this change but only if RE (Xiomara) was ok with it, and we made sure everyone was warned well in advance. Also, the change is incomplete because the README-builds.html file probably would need to change too. -kto Anthony Petrov wrote: Please review the fi

Re: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Xiomara . Jayasena
Hi Anthony, We do set ALT_BOOTDIR all the time. From Kelly: Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted by this change, but I bet quite a few people rely on this c:/jdk1.6.0 default. With enough warning you

Re: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Anthony Petrov
Hi Xiomara, Thank you for the comments! On 4/23/2009 6:27 PM Xiomara Jayasena wrote: Release Engineering uses c:\jdk ... when building on windows. We will still need that. Ups. I'm sorry about that, I really didn't know you use this path. This was the reason I initiated the discussion on the

Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms)

2009-04-23 Thread Anthony Petrov
Please review the fix for the CR mentioned in the subject. The webrev: http://cr.openjdk.java.net/~anthony/webrev-6833444.0/ I verified the fix on MS Windows platform, and it works pretty well. -- best regards, Anthony