Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-09 Thread Sergey Malenkov
Hi Fredrik, Thanks! It looks good to me. Regards, SAM On 09.01.2013 16:07, Fredrik Öhrström wrote: 2013/1/9 Sergey Malenkov : First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will be strange to provide sources for nonexistent (by default) classes. Second, *BeanInfo java f

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-09 Thread Fredrik Öhrström
2013/1/9 Sergey Malenkov : > First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will > be strange to provide sources for nonexistent (by default) classes. > Second, *BeanInfo java files are generated automatically. They are not > well-formatted and well-documented. Ok, I have up

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-09 Thread Sergey Malenkov
Hi Fredrik, > It seems to be reasonable that these sources should be part of the > src.zip and that it was a bug previously that they were not. I don't think so. First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will be strange to provide sources for nonexistent (by default)

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-07 Thread Fredrik Öhrström
2012/12/18 Sergey Malenkov : > Looks OK to me. But there are a lot of images in the > make/tools/swing-beans/beaninfo/images folder. Could you please check the > make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar > library will be packed correctly? Yes, I have verified that

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-07 Thread Alan Bateman
On 07/01/2013 13:57, Fredrik Öhrström wrote: : The makefile comments, comment on the fact that Java sources that reside inside make/tools are in fact part of the dt.jar (ie part of the jdk, not just a tool). However this is not that easy to fix, since the actual tool that generates the swing cla

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2013-01-07 Thread Fredrik Öhrström
2012/12/16 Kelly O'Hair : > Looks ok to me. But do the makefile comments need to be adjusted? The makefile comments, comment on the fact that Java sources that reside inside make/tools are in fact part of the dt.jar (ie part of the jdk, not just a tool). However this is not that easy to fix, sin

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2012-12-24 Thread Sergey Malenkov
Hi Fredrik, Looks OK to me. But there are a lot of images in the make/tools/swing-beans/beaninfo/images folder. Could you please check the make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar library will be packed correctly? Also I think that moving of java files from t

Re: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2012-12-16 Thread Kelly O'Hair
Looks ok to me. But do the makefile comments need to be adjusted? -kto On Dec 15, 2012, at 1:01 PM, Fredrik Öhrström wrote: > A few source files, coming from the generated swing BeanInfo files are > generated and stored into the wrong source directory, where the path does not > correspond to

Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

2012-12-15 Thread Fredrik Öhrström
A few source files, coming from the generated swing BeanInfo files are generated and stored into the wrong source directory, where the path does not correspond to the expected package path. This is unfortunate and makes it impossible for the smart javac wrapper to predict which source files bel