Re: Runing findbugs

2008-05-14 Thread Lars Westergren
If we did publish those results I'd want to tie it to an effort to find community members to reduce the number of findbugs warnings. I for one would be happy to contribute to that. Cheers, Lars

Runing findbugs

2008-05-13 Thread Kelly O'Hair
I'm currently looking at how we could possible include a run of findbugs in the build process, but my conclusion right now is that we cannot do it by default, it takes way to long to run findbugs over everything. (12hrs). But I could add some minor support to the Makefiles to allow someone to

Re: Runing findbugs

2008-05-13 Thread Jonathan Gibbons
Kelly, I think that running findbugs on different segments of JDK and publishing histograms of the results on the OpenJDK Quality pages would be a fine idea, but unless we can get engineers to sign up to reducing bugs found by findbugs, the histograms would be somewhat boring. -- Jon

Re: Runing findbugs

2008-05-13 Thread Peter B. Kessler
If you've figured out where to run such a checker, can we run pscan on our native sources? Last time I checked, it took 3 seconds to run on a local copy of HotSpot (and found some things that I fixed). I did try it on all the native code in the JDK, but I forget how long it took. It wasn't

Re: Runing findbugs

2008-05-13 Thread Joseph D. Darcy
I agree that having results of findbugs (and other checkers) as one of the results of the build would be a good idea. -Joe Max (Weijun) Wang wrote: Since it takes so long time, how about the release engineer running it once after every build and post the result to openjdk.java.net? Hope some

Re: Runing findbugs

2008-05-13 Thread Kelly O'Hair
Jeez, I can't even spell running right... :^{ The pscan site seems to be dead: http://www.striker.ottawa.on.ca/~aland/pscan/ Anybody know what the new public site is for pscan? --- As to when to run findbugs, my conclusion is that the only time you can run it is after the entire jdk is

Re: Runing findbugs

2008-05-13 Thread Kelly O'Hair
David Herron wrote: As the Quality group lead - I would be happy to have more quality metrics like findbugs results to publish on the site. If we did publish those results I'd want to tie it to an effort to find community members to reduce the number of findbugs warnings. And, um, it would

Re: Runing findbugs

2008-05-13 Thread Jonathan Gibbons
Kelly, There are two ways to use findbugs. It would be good to have a batch run of findbugs per build with the goal of publishing metrics. Separately, developers should be encouraged to run findbugs however works best for them, to get their findbug count down. -- Jon On May 13, 2008,

Re: Runing findbugs

2008-05-13 Thread Martin Buchholz
It looks like you want the -auxclasspath flag to findbugs. See http://findbugs.sourceforge.net/manual/ch11.html (I haven't actually tried this myself) Martin On Tue, May 13, 2008 at 4:37 PM, Kelly O'Hair [EMAIL PROTECTED] wrote: I'm currently looking at how we could possible include a run of

Re: Runing findbugs

2008-05-13 Thread Peter B. Kessler
It's possible that it got folded into -Wformat on recent gcc's. That's fine for the platforms (and bits of source) we compile with gcc, but it would be nice if we could check all our code. ... peter Kelly O'Hair wrote: Jeez, I can't even spell running right... :^{ The