Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-04-24 Thread Daniel D. Daugherty
Greetings, At long last, I can finally push the following two bug fixes to http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot (RT_Baseline): 7102323 4/4 RFE: enable Full Debug Symbols Phase 1 on Solaris 7158067 4/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect pro

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Daniel D. Daugherty
On 3/23/12 1:50 PM, Andrew Hughes wrote: - Original Message - On 3/23/12 12:08 PM, Andrew Hughes wrote: - Original Message - - Original Message - Greetings, I've backported the FDS changes to JDK7u6. Here's the webrevs: http://cr.openjdk.java.net/~dcubed/fds_revamp/7

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Andrew Hughes
- Original Message - > On 3/23/12 12:08 PM, Andrew Hughes wrote: > > > > - Original Message - > >> - Original Message - > >>> Greetings, > >>> > >>> I've backported the FDS changes to JDK7u6. Here's the webrevs: > >>> > >>> http://cr.openjdk.java.net/~dcubed/fds_revamp/71365

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Daniel D. Daugherty
On 3/23/12 12:08 PM, Andrew Hughes wrote: - Original Message - - Original Message - Greetings, I've backported the FDS changes to JDK7u6. Here's the webrevs: http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ http://cr.openjdk.java.net/~dcubed/fds_revamp

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Andrew Hughes
- Original Message - > - Original Message - > > Greetings, > > > > I've backported the FDS changes to JDK7u6. Here's the webrevs: > > > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Andrew Hughes
- Original Message - > Greetings, > > I've backported the FDS changes to JDK7u6. Here's the webrevs: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-jdk/ > http://cr.openjdk.java.net/~dcubed/

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-22 Thread Daniel D. Daugherty
Greetings, I've backported the FDS changes to JDK7u6. Here's the webrevs: http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-jdk/ http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/0-7u6-hotspot/

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-18 Thread serguei.spit...@oracle.com
Ok, thanks! Thumb up. Thanks, Serguei On 3/17/12 6:29 PM, Daniel D. Daugherty wrote: Thanks for the review. Replies embedded below... Dan, I've reviewed this: http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/ Wow, you fixed two existing bugs in the make file:

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-17 Thread Daniel D. Daugherty
Thanks for the review. Replies embedded below... Dan, I've reviewed this: http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/ Wow, you fixed two existing bugs in the make file: *make/solaris/makefiles/dtrace.make * -[ -f $(XLIBJVM_DB_G_DEBUGINFO) ] || { l

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-17 Thread serguei.spit...@oracle.com
Dan, I've reviewed this: http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/ Wow, you fixed two existing bugs in the make file: *make/solaris/makefiles/dtrace.make * -[ -f $(XLIBJVM_DB_G_DEBUGINFO) ] || { ln -s $(LIBJVM_DB_DEBUGINFO) $(XLIBJVM_DB_G_DEB

code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-16 Thread Daniel D. Daugherty
Greetings, I need code reviews for some Makefile and packaging changes. Wait, come back! They're not that scary... These are Full Debug Symbols changes... so maybe they are that scary... These changes have gone through two rounds of internal review. The following bugs are being used to revamp