Re: RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-12 Thread David Holmes
On 12/05/2015 6:27 AM, David Holmes wrote: Hi Erik, On 11/05/2015 10:31 PM, Erik Joelsson wrote: Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://

Re: RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-11 Thread David Holmes
Hi Erik, On 11/05/2015 10:31 PM, Erik Joelsson wrote: Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8039426 Web

Re: RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-11 Thread Magnus Ihse Bursie
On 2015-05-11 14:31, Erik Joelsson wrote: Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8039426 Webrev: http:

RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-11 Thread Erik Joelsson
Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8039426 Webrev: http://cr.openjdk.java.net/~erikj/8039426/webrev

gcc can target wrong instruction set when building JDK native code

2014-04-07 Thread David Holmes
I just filed this as: https://bugs.openjdk.java.net/browse/JDK-8039426 Our JDK build does not specify -march/-mtune (whereas hotspot specifies -march=i586) so JDK gets gcc's default behaviour. The default is -mtune=generic and 'generic', at least back to 4.2, means i686 - this means that the