Hi,

Sometimes one needs access to hotspot internals only for the sake of
gtests. At the moment there is no define which tells me whether I build
with gtests or not, so I add those interfaces unconditionally, with a "only
for gtests" comment.

I wonder whether it makes sense to add a define which conditionally
switches on code if we build with --with-gtests.

The argument against that would be that we may not want gtest-specific
differences to creep in but rather test what we ship.

What do you think?

Cheers, Thomas

Reply via email to