Re: strange error when running jtreg tests

2016-08-23 Thread Tiago Daitx
Gustavo brought this issue to my attention (thanks!) The cause is that Debian/Ubuntu have been setting -Wl,--as-needed for a long while [1], thus libraries must appear *after* objects referring to the library. Also, make does state that libraries shouldn't be added to LDFLAGS [2]. Regards, Tiago

Re: strange error when running jtreg tests

2016-08-18 Thread David Holmes
Hi Erik, On 18/08/2016 6:11 PM, Erik Joelsson wrote: Thank you, Here is a request for review on that change. Webrev: http://cr.openjdk.java.net/~erikj/8164297/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8164297 Fix seems to work, as reported, but why do we have: BUILD_HOTSPOT_J

Re: strange error when running jtreg tests

2016-08-18 Thread Erik Joelsson
On 2016-08-18 00:14, Andrew Hughes wrote: This seems to be a problem that keeps reoccurring in the OpenJDK build on Debian/Ubuntu systems over several years e.g. http://icedtea.classpath.org/hg/icedtea6/raw-file/tip/patches/linker-libs-order.patch (OpenJDK 6) http://icedtea.classpath.org/bug

Re: strange error when running jtreg tests

2016-08-18 Thread Erik Joelsson
Thank you, Here is a request for review on that change. Webrev: http://cr.openjdk.java.net/~erikj/8164297/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8164297 I will push this to jdk9/hs when reviewed unless anyone thinks it belongs better somewhere else. /Erik On 2016-08-17 19:

Re: strange error when running jtreg tests

2016-08-17 Thread Andrew Hughes
- Original Message - > Hi Erik, > > On 17-08-2016 12:23, Erik Joelsson wrote: > > I'm sorry, you also need this patch, which I for some reason I can't > > remember had in my local forest. > > > > diff -r a24702d4d5ab make/common/TestFilesCompilation.gmk > > --- a/make/common/TestFilesCo

Re: strange error when running jtreg tests

2016-08-17 Thread Gustavo Romero
Hi Erik, On 17-08-2016 12:23, Erik Joelsson wrote: > I'm sorry, you also need this patch, which I for some reason I can't remember > had in my local forest. > > diff -r a24702d4d5ab make/common/TestFilesCompilation.gmk > --- a/make/common/TestFilesCompilation.gmk > +++ b/make/common/TestFilesCom

Re: strange error when running jtreg tests

2016-08-17 Thread Erik Joelsson
I'm sorry, you also need this patch, which I for some reason I can't remember had in my local forest. diff -r a24702d4d5ab make/common/TestFilesCompilation.gmk --- a/make/common/TestFilesCompilation.gmk +++ b/make/common/TestFilesCompilation.gmk @@ -86,6 +86,7 @@ LANG := C, \ C

Re: strange error when running jtreg tests

2016-08-17 Thread Gustavo Romero
Hi Erik, I applied your change: diff -r 397565766eb4 make/test/JtregNative.gmk --- a/make/test/JtregNative.gmk Thu Aug 11 16:22:08 2016 -0700 +++ b/make/test/JtregNative.gmk Wed Aug 17 09:54:20 2016 -0500 @@ -79,7 +79,7 @@ ifeq ($(OPENJDK_TARGET_OS), linux) BUILD_HOTSPOT_JTREG_LIBRARIES_LDF

Re: strange error when running jtreg tests

2016-08-17 Thread Erik Joelsson
I finally took a look at this and yes, there is a bug in the makefile. This line in hotspot/make/test/JtregNative.gmk: BUILD_HOTSPOT_JTREG_EXECUTABLES_LDFLAGS_exeinvoke := -ljvm -lpthread should be: BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exeinvoke := -ljvm -lpthread Could someone who is able to

Re: strange error when running jtreg tests

2016-08-17 Thread Gustavo Romero
Sorry, again: (reading from left to right the link command). Regards, Gustavo On 17-08-2016 11:15, Gustavo Romero wrote: > Hi David, > > On 17-08-2016 00:38, David Holmes wrote: >> On 16/08/2016 8:41 AM, Gustavo Romero wrote: >>> On Ubuntu 16.04 PPC64 LE replacing -lpthread by -pthread in >>> ./

Re: strange error when running jtreg tests

2016-08-17 Thread Gustavo Romero
Hi David, On 17-08-2016 00:38, David Holmes wrote: > On 16/08/2016 8:41 AM, Gustavo Romero wrote: >> On Ubuntu 16.04 PPC64 LE replacing -lpthread by -pthread in >> ./hotspot/make/test/JtregNative.gmk:82 solves the issue on pthread_* symbols >> and >> placing -ljvm (for instance) in front of ".../

Re: strange error when running jtreg tests

2016-08-16 Thread David Holmes
On 16/08/2016 8:41 AM, Gustavo Romero wrote: Hi, I observed the same issue on Ubuntu 16.04 but not on RHEL 7.2. RHEL 7.2: https://paste.fedoraproject.org/409005/raw/ Ubuntu 16.04: https://paste.fedoraproject.org/409004/raw/ I checked on PPC64 LE arch (Ubuntu 16.04 and RHEL 7.2, logs above). I

Re: strange error when running jtreg tests

2016-08-16 Thread Maurizio Cimadamore
On 16/08/16 14:19, David Simms wrote: Another work-around is to use a "sanctioned dev kit" ("--with-devkit=") and avoid problems with "new fangled distros and tools", see: https://wiki.se.oracle.com/display/JPG/Devkit+build+instructions+for+JDK+9 This doesn't work - at least for me - it

Re: strange error when running jtreg tests

2016-08-16 Thread Maurizio Cimadamore
On 16/08/16 14:19, David Simms wrote: Another work-around is to use a "sanctioned dev kit" ("--with-devkit=") and avoid problems with "new fangled distros and tools", see: https://wiki.se.oracle.com/display/JPG/Devkit+build+instructions+for+JDK+9 Sure - or running jtreg manually (which

Re: strange error when running jtreg tests

2016-08-16 Thread David Simms
Another work-around is to use a "sanctioned dev kit" ("--with-devkit=") and avoid problems with "new fangled distros and tools", see: https://wiki.se.oracle.com/display/JPG/Devkit+build+instructions+for+JDK+9 On 16/08/16 11:39, Maurizio Cimadamore wrote: Using Ubuntu 14.04 on x64. Maurizio

Re: strange error when running jtreg tests

2016-08-16 Thread Maurizio Cimadamore
Using Ubuntu 14.04 on x64. Maurizio On 15/08/16 23:41, Gustavo Romero wrote: Hi, I observed the same issue on Ubuntu 16.04 but not on RHEL 7.2. RHEL 7.2: https://paste.fedoraproject.org/409005/raw/ Ubuntu 16.04: https://paste.fedoraproject.org/409004/raw/ I checked on PPC64 LE arch (Ubuntu

Re: strange error when running jtreg tests

2016-08-15 Thread Gustavo Romero
Hi, I observed the same issue on Ubuntu 16.04 but not on RHEL 7.2. RHEL 7.2: https://paste.fedoraproject.org/409005/raw/ Ubuntu 16.04: https://paste.fedoraproject.org/409004/raw/ I checked on PPC64 LE arch (Ubuntu 16.04 and RHEL 7.2, logs above). It fails also on Ubuntu 16.04 x64 (but I could

Re: strange error when running jtreg tests

2016-08-15 Thread Maurizio Cimadamore
Yes - other colleagues seeing this too Maurizio On 13/08/16 00:56, David Holmes wrote: Did you do a clean first? I've not seen nor heard of this before.

Re: strange error when running jtreg tests

2016-08-12 Thread David Holmes
On 13/08/2016 12:50 AM, Maurizio Cimadamore wrote: On 12/08/16 14:12, David Holmes wrote: On 12/08/2016 11:06 PM, Maurizio Cimadamore wrote: Hi, I've encountered this error when running jtreg tests from make using the following command line make test JT_HOME= TEST=jdk_util * For target su

Re: strange error when running jtreg tests

2016-08-12 Thread Maurizio Cimadamore
On 12/08/16 14:12, David Holmes wrote: On 12/08/2016 11:06 PM, Maurizio Cimadamore wrote: Hi, I've encountered this error when running jtreg tests from make using the following command line make test JT_HOME= TEST=jdk_util * For target support_test_hotspot_jtreg_native_support_exeinvoke_BU

Re: strange error when running jtreg tests

2016-08-12 Thread David Holmes
On 12/08/2016 11:06 PM, Maurizio Cimadamore wrote: Hi, I've encountered this error when running jtreg tests from make using the following command line make test JT_HOME= TEST=jdk_util * For target support_test_hotspot_jtreg_native_support_exeinvoke_BUILD_TEST_invoke_link: /w/lt/9/dev/build/li

strange error when running jtreg tests

2016-08-12 Thread Maurizio Cimadamore
Hi, I've encountered this error when running jtreg tests from make using the following command line make test JT_HOME= TEST=jdk_util * For target support_test_hotspot_jtreg_native_support_exeinvoke_BUILD_TEST_invoke_link: /w/lt/9/dev/build/linux-x86_64-normal-server-release/support/test/hot