On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov wrote:
> I found [yet another
> typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948)
> ...
I didn't think "JVMInvokeMethodSlack" was a typo. I think it's the idea of
"s
On Thu, 14 Apr 2022 10:38:33 GMT, Yi Yang wrote:
>I found [yet another
>typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948),
> I wonder if you can merge this into your patch so that I do not need to
>submit a new PR for it? Thanks.
I think i
et/jdk/commit/48c75498060f076287d3d44c49934db9ac70887b
Stats: 65 lines in 28 files changed: 0 ins; 0 del; 65 mod
8284853: Fix various 'expected' typo
Reviewed-by: bpb, ihse
-
PR: https://git.openjdk.java.net/jdk/pull/8231
ision:
>
> 8284853: Fix various 'expected' typo
> improve test log
Build changes look good.
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8231
ision:
>
> 8284853: Fix various 'expected' typo
> improve test log
I found [yet another
typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948),
I wonder if you can merge this into your patch so that I do not need to submit
a new PR f
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8284853: Fix various 'expected' typo
improve test log
--
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
test/jdk/java/lang/StackWalker/StackStreamTest.java line 218:
> 216: private static void equalsOrThrow(String label, List list,
>
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Expect the Unexpeted.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8231
Found various typos of expected: `exepected`, `exept`, `epectedly`, `expeced`,
`Unexpeted`, etc.
-
Commit messages:
- [PATCH] Fix 'expected' typo
- [PATCH] Fix 'expected' typo
- [PATCH] Fix 'expected' typo
Changes: https://git.openjdk.java.net/jdk/
Hi,
Could I have review of a typo.
Testing: jdk/jdk/jfr
Thanks
Erik
-
Commit messages:
- Initial
Changes: https://git.openjdk.java.net/jdk/pull/5803/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5803&range=00
Issue: https://bugs.openjdk.java.net/br
hanged: 0 ins; 0 del; 6 mod
8257208: Fix typo in doc/building.md
Reviewed-by: ihse
-
PR: https://git.openjdk.java.net/jdk/pull/1365
On Fri, 27 Nov 2020 14:22:01 GMT, Magnus Ihse Bursie wrote:
>> overriden -> overridden
>
> Marked as reviewed by ihse (Reviewer).
@magicus Thanks for reviewing! Now could you please sponsor this change? Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/1365
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man
wrote:
> overriden -> overridden
Marked as reviewed by ihse (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1365
overriden -> overridden
-
Commit messages:
- 8257208: Fix typo in doc/building.md
Changes: https://git.openjdk.java.net/jdk/pull/1365/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1365&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8257208
issue for this fix:
> https://bugs.openjdk.java.net/browse/JDK-8257208
>
> Please update the PR title to `8257208: Fix typo in doc/building.md`.
@magicus Done! Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/1365
dk.java.net/browse/JDK-8257208
Please update the PR title to `8257208: Fix typo in doc/building.md`.
-
PR: https://git.openjdk.java.net/jdk/pull/1365
Looks good.
/Erik
On 2020-03-11 02:54, Magnus Ihse Bursie wrote:
I unfortunately forget a comma in two places in JDK-8240820, which
makes the help output incorrect.
Bug: https://bugs.openjdk.java.net/browse/JDK-8240866
Patch inline:
diff --git a/make/autoconf/flags-cflags.m4
b/make/autoconf/
I unfortunately forget a comma in two places in JDK-8240820, which makes
the help output incorrect.
Bug: https://bugs.openjdk.java.net/browse/JDK-8240866
Patch inline:
diff --git a/make/autoconf/flags-cflags.m4 b/make/autoconf/flags-cflags.m4
--- a/make/autoconf/flags-cflags.m4
+++ b/make/autoco
+1. Missed this in the review.
Mandy
On 6/7/19 4:36 PM, Jonathan Gibbons wrote:
The fix for JDK-8224257 had a transposition typo, putting a ';'
outside a quoted string instead of inside it.
JBS: https://bugs.openjdk.java.net/browse/JDK-8225496
-- Jon
$ hg diff -R op
The fix for JDK-8224257 had a transposition typo, putting a ';' outside
a quoted string instead of inside it.
JBS: https://bugs.openjdk.java.net/browse/JDK-8225496
-- Jon
$ hg diff -R open
diff -r fd61ef6c4091 make/jdk/src/classes/build/tools/fixuppandoc/Main.java
--- a/make/jdk/s
Hi David,
On 03/25/2019 09:11 PM, David Holmes wrote:
Looks good Gustavo.
Thanks a lot for the quick review.
Pushed to jdk/jdk since it's a trivial change.
Best regards,
Gustavo
Looks good Gustavo.
Thanks,
David
On 26/03/2019 9:53 am, Gustavo Romero wrote:
Hi,
Could the following trivial change be reviewed, please?
bug : https://bugs.openjdk.java.net/browse/JDK-8221434
webrev : http://cr.openjdk.java.net/~gromero/8221434/v1/
Thank you and best regards,
Gustavo
Hi,
Could the following trivial change be reviewed, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8221434
webrev : http://cr.openjdk.java.net/~gromero/8221434/v1/
Thank you and best regards,
Gustavo
Magnus, Erik,
thanks for your review.
-- Igor
> On Mar 23, 2018, at 8:30 AM, Magnus Ihse Bursie
> wrote:
>
>
>> 23 mars 2018 kl. 16:25 skrev Erik Joelsson :
>>
>> Hello Igor,
>>
>> This looks good, but please also run "make update-build-docs" so that the
>> html file also gets regenerated
> 23 mars 2018 kl. 16:25 skrev Erik Joelsson :
>
> Hello Igor,
>
> This looks good, but please also run "make update-build-docs" so that the
> html file also gets regenerated before pushing.
Looks good to me too.
/Magnus
>
> /Erik
>
>
>> On 2018-03-23 08:13, Igor Ignatyev wrote:
>> http:
Hello Igor,
This looks good, but please also run "make update-build-docs" so that
the html file also gets regenerated before pushing.
/Erik
On 2018-03-23 08:13, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8200180/webrev.00/index.html
3 lines changed: 0 ins; 0 del; 3 mod;
http://cr.openjdk.java.net/~iignatyev//8200180/webrev.00/index.html
> 3 lines changed: 0 ins; 0 del; 3 mod;
Hi all,
could you please review this small fix for run-test framework documentation?
VM_OTIONS was used instead of VM_OPTIONS at several places, the fix is obvious
s/VM_OTIONS/VM_OPTION
Erik:
I seem to have fat fingered some extra letters into a makefile in a
recent change. Those need to be removed. Thanks to Magnus who saw it,
albeit too late to stop me.
Bug: https://bugs.openjdk.java.net/browse/JDK-8191744
Patch:
diff -r 53440b6353b6 test/make/TestCopyFiles.gmk
--- a/test/
I seem to have fat fingered some extra letters into a makefile in a
recent change. Those need to be removed. Thanks to Magnus who saw it,
albeit too late to stop me.
Bug: https://bugs.openjdk.java.net/browse/JDK-8191744
Patch:
diff -r 53440b6353b6 test/make/TestCopyFiles.gmk
--- a/test/make/T
Thank you Magnus
Best regards,
Stanislav Smirnov
> 7 дек. 2016 г., в 11:23, Magnus Ihse Bursie
> написал(а):
>
>> On 2016-11-30 12:09, Stanislav Smirnov wrote:
>> Hi,
>>
>> please review this minor fix of a typo I have noticed in "bash configure”
>
On 2016-11-30 12:09, Stanislav Smirnov wrote:
Hi,
please review this minor fix of a typo I have noticed in "bash configure”
output when required X11 libraries are missing.
JBS: https://bugs.openjdk.java.net/browse/JDK-8170530
<https://bugs.openjdk.java.net/browse/JDK-8170530>
w
Hi,
please review this minor fix of a typo I have noticed in "bash configure”
output when required X11 libraries are missing.
JBS: https://bugs.openjdk.java.net/browse/JDK-8170530
<https://bugs.openjdk.java.net/browse/JDK-8170530>
webrev: http://cr.openjdk.java.net/~stsmirno/817053
I will sponsor it. Looks good to me.
/Erik
On 2016-05-02 14:23, Severin Gehwolf wrote:
On Fri, 2016-04-29 at 14:51 +0200, Matthias Klose wrote:
The build 116 broke the zero build on s390x, this is just a simple typo. Please
apply. This at least lets the first build finish in the bootcycle
On Fri, 2016-04-29 at 14:51 +0200, Matthias Klose wrote:
> The build 116 broke the zero build on s390x, this is just a simple typo.
> Please
> apply. This at least lets the first build finish in the bootcycle build
> before
> the vm crashes in the second one.
>
> Howe
The build 116 broke the zero build on s390x, this is just a simple typo. Please
apply. This at least lets the first build finish in the bootcycle build before
the vm crashes in the second one.
However this build change broke the build on all archs which are not explicitly
handled in this
Hi Erik
On 04/28/16 07:06, Chris Hegarty wrote:
On 28 Apr 2016, at 15:00, Erik Joelsson wrote:
An apparent typo has appeared in common/autoconf/compare.sh.in which I think
originates from a merge changeset. It prevents clean comparisons from being
done so I would like to have it fixed asap
On 28 Apr 2016, at 15:00, Erik Joelsson wrote:
> An apparent typo has appeared in common/autoconf/compare.sh.in which I think
> originates from a merge changeset. It prevents clean comparisons from being
> done so I would like to have it fixed asap.
>
> Bug: https://bugs.o
An apparent typo has appeared in common/autoconf/compare.sh.in which I
think originates from a merge changeset. It prevents clean comparisons
from being done so I would like to have it fixed asap.
Bug: https://bugs.openjdk.java.net/browse/JDK-8155641
Patch:
diff -r d8b1e1832b0e common/autoconf
Looks good.
Thanks,
David
-
On 29/02/2016 8:19 PM, Erik Joelsson wrote:
In JDK-8150201, some debug flags were corrected. In one of the
overrides, the file name was misspelled so the debug flag correction is
not in effect.
Bug: https://bugs.openjdk.java.net/browse/JDK-8150822
Patch:
diff -
Looks good to me.
/Magnus
> 29 feb. 2016 kl. 11:19 skrev Erik Joelsson :
>
> In JDK-8150201, some debug flags were corrected. In one of the overrides, the
> file name was misspelled so the debug flag correction is not in effect.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8150822
>
> P
In JDK-8150201, some debug flags were corrected. In one of the
overrides, the file name was misspelled so the debug flag correction is
not in effect.
Bug: https://bugs.openjdk.java.net/browse/JDK-8150822
Patch:
diff -r 63a9e10565c4 make/solaris/makefiles/amd64.make
--- a/make/solaris/makefiles
Looks good to me.
/Erik
On 2015-10-26 18:30, Omair Majid wrote:
(moving from jdk9-dev)
Hi,
I have created a webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/
Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]
Reviewed-by: omajid
(moving from jdk9-dev)
Hi,
I have created a webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/
Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]
Reviewed-by: omajid, prr
Contributed-by: Matthias Klose
Regards,
Omair
* Philip Race
sson wrote:
> >> Hello Severin,
> >>
> >> Thank you for the bugfix. It does indeed look like a typo. I can sponsor
> >> the change for you. However, to satisfy legal requirements, you will
> >> need to send the patch directly to us. Since it's small, you ca
The change is now pushed to jdk9. Thanks!
/Erik
On 2014-10-16 17:04, Severin Gehwolf wrote:
Hi Erik,
On Thu, 2014-10-16 at 16:52 +0200, Erik Joelsson wrote:
Hello Severin,
Thank you for the bugfix. It does indeed look like a typo. I can sponsor
the change for you. However, to satisfy legal
Hi Erik,
On Thu, 2014-10-16 at 16:52 +0200, Erik Joelsson wrote:
> Hello Severin,
>
> Thank you for the bugfix. It does indeed look like a typo. I can sponsor
> the change for you. However, to satisfy legal requirements, you will
> need to send the patch directly to us. Since
Hello Severin,
Thank you for the bugfix. It does indeed look like a typo. I can sponsor
the change for you. However, to satisfy legal requirements, you will
need to send the patch directly to us. Since it's small, you can just
paste it in a mail to the mailing list and it will be
quot;$a" ==
"xx" ]; then echo BAD; else echo GOOD; fi)
It should print GOOD, but prints BAD.
As it turns out there is a typo in common/autoconf/jdk-options.m4
webrev is here:
https://jerboaa.fedorapeople.org/bugs/openjdk/JDK-UNKNOWN-build-dev/webrev.00/
Could someone please spon
Magnus:
Bug: https://bugs.openjdk.java.net/browse/JDK-8019219
The default target in CompileNativeLibraries.gmk and
CompileLaunchers.gmk is spelled "defalt". This does not affect
functionality.
Webrev:
http://cr.openjdk.java.net/~ihse/JDK-8019219-correct-target-typo/webrev.01
k.java.net/~ihse/JDK-8019219-correct-target-typo/webrev.01
/Magnus
Bug: https://bugs.openjdk.java.net/browse/JDK-8019219
The default target in CompileNativeLibraries.gmk and
CompileLaunchers.gmk is spelled "defalt". This does not affect
functionality.
Webrev:
http://cr.openjdk.java.net/~ihse/JDK-8019219-correct-target-typo/webrev.01
/Magnus
On 04/24/13 11:04 AM, Jonathan Gibbons wrote:
from running configure on Windows, typo: "inlude"
checking headful support... inlude support for both headful and headless
-- Jon
Thank you.
This is already noted in bug #8008944 "build-infra: clean up typos"
http://bugs
from running configure on Windows, typo: "inlude"
checking headful support... inlude support for both headful and headless
-- Jon
On 02/06/2013 07:17 PM, Jonathan Gibbons wrote:
common/makefiles/JavaCompilation.gmk
line 162
dechipher.
-- Jon
line 518
buliding
common/makefiles/JavaCompilation.gmk
line 162
dechipher.
-- Jon
diff --git a/README-builds.html b/README-builds.html
--- a/README-builds.html
+++ b/README-builds.html
@@ -1429,7 +1429,7 @@
build output is to go.
The default output directory will be build/platform.
-ALT_SLASHJAVA
+
56 matches
Mail list logo
