Re: Need reviewer

2009-10-15 Thread Alan Bateman
Kelly O'Hair wrote: Mark Reinhold wrote: Okay, I can live with this. Thanks. (At the risk of stating the obvious: Please be sure to use hg mv when you rename these files, otherwise the historical changeset trail will be broken.) Will do. -kto Sorry, I wasn't paying attention to this

Fix for 6888888 breaks the build

2009-10-15 Thread Andrew John Hughes
The fix for bug 688: http://hg.openjdk.java.net/jdk7/build/jdk/rev/14bd992a breaks the build as it tries to use javah from ALT_JDK_IMPORT_DIR (via JAVA_TOOLS_DIR) which is not set on normal builds. The README tells the user to set ALT_BOOTDIR and changing JAVA_TOOLS_DIR to be set to BOOTD

hg: jdk7/build: 6891677: java/build integrate zero assembler JDK changes

2009-10-15 Thread ahughes
Changeset: 608937d41381 Author:gbenson Date: 2009-10-15 13:26 +0100 URL: http://hg.openjdk.java.net/jdk7/build/rev/608937d41381 6891677: java/build integrate zero assembler JDK changes Summary: Build changes for the Zero assembler port Reviewed-by: ohair, tbell ! make/hotspot-rules

hg: jdk7/build/corba: 6891677: java/build integrate zero assembler JDK changes

2009-10-15 Thread ahughes
Changeset: 34a68fa0680b Author:gbenson Date: 2009-10-15 13:28 +0100 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/34a68fa0680b 6891677: java/build integrate zero assembler JDK changes Summary: Build changes for the Zero assembler port Reviewed-by: ohair, tbell ! make/common/

hg: jdk7/build/jdk: 6891677: java/build integrate zero assembler JDK changes

2009-10-15 Thread ahughes
Changeset: e2de121c27c4 Author:gbenson Date: 2009-10-15 13:27 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e2de121c27c4 6891677: java/build integrate zero assembler JDK changes Summary: Build changes for the Zero assembler port Reviewed-by: ohair, tbell ! make/common/De

Re: Review request: Zero buildsystem changes

2009-10-15 Thread Andrew John Hughes
2009/10/15 Tim Bell : > Gary Benson wrote: > >> As an update to my previous message, the HotSpot part of this patch >> was tested and pushed to hotspot-comp last night, so the remaining >> code for review is this: >> >>   http://cr.openjdk.java.net/~gbenson/zero-11-build/ >> >> I'm going on vacatio

Re: Review request: Zero buildsystem changes

2009-10-15 Thread Gary Benson
Andrew John Hughes wrote: > 2009/10/15 Tim Bell : > > Gary Benson wrote: > > > As an update to my previous message, the HotSpot part of this > > > patch was tested and pushed to hotspot-comp last night, so the > > > remaining code for review is this: > > > > > >   http://cr.openjdk.java.net/~gbenso

Re: Fix for 6888888 breaks the build

2009-10-15 Thread Tim Bell
Andrew John Hughes wrote: > The fix for bug 688: > > http://hg.openjdk.java.net/jdk7/build/jdk/rev/14bd992a > > breaks the build as it tries to use javah from ALT_JDK_IMPORT_DIR (via > JAVA_TOOLS_DIR) which is not set on normal builds. > The README tells the user to set ALT_BOOTDIR and ch

Re: Fix for 6888888 breaks the build

2009-10-15 Thread Andrew John Hughes
2009/10/15 Tim Bell : > Andrew John Hughes wrote: >> The fix for bug 688: >> >> http://hg.openjdk.java.net/jdk7/build/jdk/rev/14bd992a >> >> breaks the build as it tries to use javah from ALT_JDK_IMPORT_DIR (via >> JAVA_TOOLS_DIR) which is not set on normal builds. >> The README tells the u

Re: Fix for 6888888 breaks the build

2009-10-15 Thread Jonathan Gibbons
Andrew John Hughes wrote: 2009/10/15 Tim Bell : Andrew John Hughes wrote: The fix for bug 688: http://hg.openjdk.java.net/jdk7/build/jdk/rev/14bd992a breaks the build as it tries to use javah from ALT_JDK_IMPORT_DIR (via JAVA_TOOLS_DIR) which is not set on normal builds. The R

Re: Fix for 6888888 breaks the build

2009-10-15 Thread Tim Bell
> Andrew John Hughes wrote: (snip!) >> I think there's still an issue here that makes this patch worth >> pushing. The 688 fix didn't cause the bug, but merely made it >> visible to a lot more people. So 6889255 will only hide it again. >> The build uses JAVA_TOOLS_DIR for javac, javah and j