Make File Changes For CR4239752

2012-10-22 Thread Dan Xu
Hi, I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and comp

Re: Make File Changes For CR4239752

2012-10-22 Thread Magnus Ihse Bursie
Dan, This does not look like a change that should require any changes to the Makefiles in build-infra. Did you try "make clean" before building with your fixes? I think there are some issues with the automatic removing of generated header files when the last native method is removed from a cla

Re: Make File Changes For CR4239752

2012-10-22 Thread Kelly O'Hair
I agree Magnus, should have worked. It looks like makefiles/mapfiles/libjava/mapfile-vers was changed, and that should do it. I assume the .so is dependent on the mapfiles right? --- Dan, If a clean build fails, please send us cut&paste of the error. -kto On Oct 22, 2012, at 4:12 PM, Magnus I

Re: Make File Changes For CR4239752

2012-10-22 Thread Dan Xu
I just cleaned the build by running "make dist-clean" command, and then configure and re-make jdk. But the error still exists. Here is the error message, c:/cygwin/home/danxu/dev/Jdk/tl8/jdk/src/windows/native/java/io/WinNTFileSystem_md.c(46) : fatal error C1083: Cannot open include file: 'jav