There are several similarities between jdk/test/Makefile and
langtools/test/Makefile. This makes it possible to run tests from either
one in build-infra (the new build system) by using the target "test". In
jdk/test/Makefile there is a test for an external variable
ALT_OUTPUTDIR, which directs
The following patch will allow build-infra to perform builds on MinGW/MSys.
It also updates the case for cygwin, with the two changes:
1) It replaces a $(subst) from / to \ which acted on output from cygpath
-m (mixed mode), with just cygpath -w (windows mode, i.e. mixed mode but
with \ instea
Here is a webrev of the latest changes in build-infra that we want to
push to the build forest.
http://cr.openjdk.java.net/~ihse/build-infra-integ/
For jdk, langtools, corba, jaxp and jaxws, all changes are in the
makefiles directory.
No patches from hotspot are needed at this time. (See sep
This change is not right.
We should not use the name ALT_ anything in this makefile, it is an independent
Makefile.
For better or worse, it does not share the build make logic at all.
The names ALT_OUTPUTDIR and ABS_OUTPUTDIR could just be something like
TEST_OUTPUT_ROOT
or something without t
Thank you, Eric.
I have updated my change and tested it locally. Everything works well.
Here is the latest webrev, please review the change,
http://cr.openjdk.java.net/~dxu/4239752/webrev/. Thanks!
-Dan
On Wed 24 Oct 2012 04:55:46 AM PDT, Erik Joelsson wrote:
Alan seems to prefer explicit g
I note that there are some notes on the OpenJDK website about running tests.
See here: http://openjdk.java.net/jtreg/#makefile
In particular, it includes this text:
When using these targets, it is recommended to set the following
variables, either as environment variables or on the "make" comm
It has been my experience that using cygpath -w created problems with shell
escape logic,
and that is why cygpath -m with a make level subst change is done, it was less
problematic.
I don't understand why you would even want to change the cygwin logic at all,
if it isn't broken why mess with it
If these changes are integrated and on their way to jdk8/jdk8 already, it's
water under the bridge, we need to
see them earlier in the future.
I appreciate the information though, I looked at these changesets and they look
fine, but it is extremely
hard to review makefile changes and know that
As I said, the name ALT_OUTPUTDIR is already used in jdk/test/Makefile. That is
the reason I used it. Of course it could be called anything, but if it is not
called the same thing across repos, we get a hard time for no good reason.
The only important thing for integration with build-infra is th
On 26/10/2012 12:51 AM, Magnus Ihse Bursie wrote:
Here is a webrev of the latest changes in build-infra that we want to
push to the build forest.
http://cr.openjdk.java.net/~ihse/build-infra-integ/
For jdk, langtools, corba, jaxp and jaxws, all changes are in the
makefiles directory.
I've loo
10 matches
Mail list logo
