Would be great if someone could look at this, thanks.
/Erik
On 2013-06-18 12:21, Erik Joelsson wrote:
Thanks,
I hit another problem after fixing this though. On windows, when
building the sec-bin.zip, the root directory for the zip is
$(JDK_OUTPUTDIR), which at the time contains something ar
I found the problem. It seems the new version of sed isn't ignoring \r
characters in the same way as the old one must have. The fix is simple
so posting it inline below. The output from cl.exe contains a \r at the
end of each line. This needs to be stripped off before meaningful
comparisons can
Looks ok to me Erik.
-Chris.
On 27/06/2013 09:31, Erik Joelsson wrote:
I found the problem. It seems the new version of sed isn't ignoring \r
characters in the same way as the old one must have. The fix is simple
so posting it inline below. The output from cl.exe contains a \r at the
end of eac
Would be great if someone could take a look at this, thanks.
/Erik
On 2013-06-11 12:18, Erik Joelsson wrote:
I managed to fix this with a rather simple patch. The whole thing is a
bit of a mess, but this at least restores the advertised functionality.
http://cr.openjdk.java.net/~erikj/8016303
Would be great if someone could take a look at this, thanks.
/Erik
On 2013-06-18 16:38, Erik Joelsson wrote:
The log level 'trace' is broken on both mac and solaris. When trace is
used, the shell variable is overridden to do the following:
1. Add -x to echo each line that gets executed. This
Hi Erik,
as Vladimir explained, we have a special staging repository for our
PPC64/AIX port:
I would be happy if you could push the changes right into the build-infra
repositories and we will then get them into our staging repository via
jdk8/jdk8.
Otherwise I'll have to push them to our staging
On 26/06/2013 17:53, Vladimir Kozlov wrote:
Erik,
We have special staging forest for PPC64/AIX port:
http://hg.openjdk.java.net/ppc-aix-port/stage
We collect Hotspot and JDK changes there for testing before pushing
into main sources in a future. But some general fixes we push directly
into o
On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson wrote:
> **
> Hello Volker,
>
> I wasn't aware of this project until now. From what I (now) understand,
> generic patches can go into jdk8 repos, but port specific things need to go
> to staging and go in with the rest later. These changes contain a
Changeset: f5eb23490e6a
Author:erikj
Date: 2013-06-27 09:27 +0200
URL: http://hg.openjdk.java.net/jdk8/build/rev/f5eb23490e6a
8017047: Can't use --with-java-devtools and --with-devkit at the same time
Reviewed-by: tbell
! common/autoconf/basics.m4
! common/autoconf/generated-config
On 27/06/2013 7:16 PM, Erik Joelsson wrote:
Would be great if someone could take a look at this, thanks.
Looks reasonable to me.
David
/Erik
On 2013-06-18 16:38, Erik Joelsson wrote:
The log level 'trace' is broken on both mac and solaris. When trace is
used, the shell variable is overridd
Do you expecte me to test it?I will be glad to, just that I never before
built a patch, only from main branches.
On Jun 27, 2013 12:14 PM, "Erik Joelsson" wrote:
> Would be great if someone could take a look at this, thanks.
>
> /Erik
>
> On 2013-06-11 12:18, Erik Joelsson wrote:
>
>> I managed t
Hi Erik,
we have no polices which are carved in stone:) It's all done
informally and by common sense.
The main reason for the ppc-aix-port/stage repository is to have a
sandbox for in-depth review and testing of changes we had to make in
shared code before pushing them to the main repository (and
Erik,
Thanks for your quick fix. It looks good to me.
-Dan
On 06/27/2013 01:53 AM, Chris Hegarty wrote:
Looks ok to me Erik.
-Chris.
On 27/06/2013 09:31, Erik Joelsson wrote:
I found the problem. It seems the new version of sed isn't ignoring \r
characters in the same way as the old one mu
Erik:
Looks good. Approved.
Tim
I found the problem. It seems the new version of sed isn't ignoring \r
characters in the same way as the old one must have. The fix is simple
so posting it inline below. The output from cl.exe contains a \r at
the end of each line. This needs to be stripped o
Erik:
Thanks for the reminder. This looks good. Approved.
Tim
Would be great if someone could look at this, thanks.
/Erik
On 2013-06-18 12:21, Erik Joelsson wrote:
Thanks,
I hit another problem after fixing this though. On windows, when
building the sec-bin.zip, the root directory for t
Erik:
Looks good. Approved.
Tim
Would be great if someone could take a look at this, thanks.
/Erik
On 2013-06-11 12:18, Erik Joelsson wrote:
I managed to fix this with a rather simple patch. The whole thing is
a bit of a mess, but this at least restores the advertised
functionality.
htt
Hi, Volker.
I think that the right thing for this change [1] is for you to push into
ppc-aix-port/stage once you get the necessary reviews (presumably Erik and
possibly Alan). While your changeset contains some general purpose updates, it
also contains PPC/AIX-specific files which can't be add
On 6/27/13 10:16 AM, Iris Clark wrote:
Hi, Volker.
I think that the right thing for this change [1] is for you to push into
ppc-aix-port/stage once you get the necessary reviews (presumably Erik and
possibly Alan). While your changeset contains some general purpose updates, it
also contains
Hi Erik
Looks good to me as well. Approved.
Tim
On 06/27/13 05:21 AM, David Holmes wrote:
On 27/06/2013 7:16 PM, Erik Joelsson wrote:
Would be great if someone could take a look at this, thanks.
Looks reasonable to me.
David
/Erik
On 2013-06-18 16:38, Erik Joelsson wrote:
The log lev
Looks fine to me too ... I wish I'd seen this 30 seconds ago.
I literally just hit this bug on mac and filed a dup (which I'll close)
and then saw this RFR.
BTW What I'm trying to do is see the gcc compiler options that
are actually used on Mac. debug and info options didn't
reveal anything. What
Am I wrong in thinking that running "build//config.status --recheck"
should alleviate the "you need to re-run configure" condition that happens when
you pull in new sources? I think it needs to touch some config files if they
are unchanged or whatever test is blocking the build needs to conside
21 matches
Mail list logo
