Mapfiles and static linking of standard libraries (was: Why do we need both - export maps AND -fvisibility=hidden/__attribute__((visibility("default"))))

(Adding in build-dev since we're moving into the jdk build as well now.) On 2014-02-17 17:39, Volker Simonis wrote: On Mon, Feb 17, 2014 at 4:08 PM, Dmitry Samersoff wrote: Dan, It was my bad - missed two related threads. We have two problems related to map files: 1. We have hand-written ma

Re: Mapfiles and static linking of standard libraries

Note that we (hotspot) do use a mapfile on OSX. This was needed to avoid every symbol in libjvm being exported resulting in the wrong versions of operator new/delete being used. David On 19/02/2014 7:22 PM, Magnus Ihse Bursie wrote: (Adding in build-dev since we're moving into the jdk build a

Re: 8032443: ,Java Access Bridge version strings need to be fixed

On 2014-02-18 05:22, Pete Brunet wrote: Please review this change: http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/ for this bug: https://bugs.openjdk.java.net/browse/JDK-8032443 Some resource compiler defines are need so the JAB DLLs Properties sheet will have the proper information

Re: RFR: JDK-8035187: Move fontconfig src files to make/data

On 2014-02-18 17:40, Tim Bell wrote: Hi Erik: These files are used as input to a build tool to create files in the lib output directory. Since they aren't normal properties files to be compiled, cleaned or copied to the classes dir, they should be moved to the make/data dir. I also unified th

Re: Mapfiles and static linking of standard libraries (was: Why do we need both - export maps AND -fvisibility=hidden/__attribute__((visibility("default"))))

Hi, please see some comments inline. More to follow... On Wed, Feb 19, 2014 at 10:22 AM, Magnus Ihse Bursie wrote: > (Adding in build-dev since we're moving into the jdk build as well now.) > > On 2014-02-17 17:39, Volker Simonis wrote: >> >> On Mon, Feb 17, 2014 at 4:08 PM, Dmitry Samersoff >>

Re: RFR: Allow using a system installed libpng

On 2014-02-17 10:16, Erik Joelsson wrote: At least to me this looks good, but better let Magnus and Andrew have their say too. Looks good to me! /Magnus

(XS) RFR: JDK-8028770 LIBARCHNAME should not be used in CompileLauncher.gmk

I sent this some days ago but it seems it never reached the list. :-( I'll give it a new try. Here's a trivial one. As reported by Jeremy Manson, LIBARCHNAME as defined in CompileLauncher.gmk seems to be i586 in 32-bit x86 instead of being i386. It's using the wrong make variable. Fortunately

Re: (XS) RFR: JDK-8028770 LIBARCHNAME should not be used in CompileLauncher.gmk

Hi Magnus: I sent this some days ago but it seems it never reached the list. :-( I'll give it a new try. Here's a trivial one. As reported by Jeremy Manson, LIBARCHNAME as defined in CompileLauncher.gmk seems to be i586 in 32-bit x86 instead of being i386. It's using the wrong make variable

Re: RFR: Allow using a system installed libpng

* Magnus Ihse Bursie [2014-02-19 06:59]: > On 2014-02-17 10:16, Erik Joelsson wrote: > >At least to me this looks good, but better let Magnus and Andrew > >have their say too. > > Looks good to me! Thanks for the reviews, everyone! I have filed https://bugs.openjdk.java.net/browse/JDK-8035341 t

Re: Mapfiles and static linking of standard libraries (was: Why do we need both - export maps AND -fvisibility=hidden/__attribute__((visibility("default"))))

On Wed, Feb 19, 2014 at 5:10 PM, Jeremy Manson wrote: > > > > On Wed, Feb 19, 2014 at 1:22 AM, Magnus Ihse Bursie > wrote: >> >> (Adding in build-dev since we're moving into the jdk build as well now.) >> >> On 2014-02-17 17:39, Volker Simonis wrote: >>> >>> On Mon, Feb 17, 2014 at 4:08 PM, Dmitr

RE: RFR: Allow using a system installed libpng

Hi, Omair. > Can someone please point me some docs that explains what I need to do to this > bug once I have pushed the fix? The short answer is "nothing, the bug will be automatically updated". A slightly longer answer may be found on this page: http://openjdk.java.net/sponsor/ See the last