Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

2015-12-15 Thread Jaroslav Bachorik
On 15.12.2015 08:03, Alan Bateman wrote: On 14/12/2015 16:55, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class UsageTrackerClient

Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

2015-12-15 Thread Erik Joelsson
Build changes look good to me. /Erik On 2015-12-14 17:55, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class UsageTrackerClient is a

RFR: JDK-8145391: Updated jprt.properties, devtools, jib and readme with SS12u4

2015-12-15 Thread Erik Joelsson
The default compiler for Solaris was changed in build 96. The jprt configuration, jib, devtools and readme needs to be updated to reflect this. In the readme, there are some other left overs from other compiler changes that also need to be tweaked. Bug: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: JDK-8145391: Updated jprt.properties, devtools, jib and readme with SS12u4

2015-12-15 Thread Magnus Ihse Bursie
On 2015-12-15 11:37, Erik Joelsson wrote: The default compiler for Solaris was changed in build 96. The jprt configuration, jib, devtools and readme needs to be updated to reflect this. In the readme, there are some other left overs from other compiler changes that also need to be tweaked. Bu

Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

2015-12-15 Thread Magnus Ihse Bursie
On 2015-12-14 17:55, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class UsageTrackerClient is accessing RuntimeMXBean.getInputArgumen

Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

2015-12-15 Thread Magnus Ihse Bursie
On 2015-12-15 04:27, Martin Buchholz wrote: My current mental model is configured cpus >= online cpus >= allowed cpus In a traditional system they are all the same. I experimented and saw that cpusets are indeed turned on in some systems used for testing at Google. I.e. allowed cpus is a strict

Re: RFR: JDK-8145391: Updated jprt.properties, devtools, jib and readme with SS12u4

2015-12-15 Thread Erik Joelsson
I missed adding two files. New webrev: http://cr.openjdk.java.net/~erikj/8145391/webrev.02/ /Erik On 2015-12-15 14:01, Magnus Ihse Bursie wrote: On 2015-12-15 11:37, Erik Joelsson wrote: The default compiler for Solaris was changed in build 96. The jprt configuration, jib, devtools and readme

Re: RFR: JDK-8145391: Updated jprt.properties, devtools, jib and readme with SS12u4

2015-12-15 Thread Tim Bell
Erik: I missed adding two files. New webrev: http://cr.openjdk.java.net/~erikj/8145391/webrev.02/ /Erik On 2015-12-15 14:01, Magnus Ihse Bursie wrote: On 2015-12-15 11:37, Erik Joelsson wrote: The default compiler for Solaris was changed in build 96. The jprt configuration, jib, devtools an

Re: RFR: JDK-8145391: Updated jprt.properties, devtools, jib and readme with SS12u4

2015-12-15 Thread Magnus Ihse Bursie
On 2015-12-15 15:29, Erik Joelsson wrote: I missed adding two files. New webrev: http://cr.openjdk.java.net/~erikj/8145391/webrev.02/ Looks good to me. /Magnus /Erik On 2015-12-15 14:01, Magnus Ihse Bursie wrote: On 2015-12-15 11:37, Erik Joelsson wrote: The default compiler for Solaris w

Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

2015-12-15 Thread Martin Buchholz
Actually calling nproc as a separate process at runtime is interesting but totally unorthodox. I think the configury pain is the usual: detecting sched.h, sched_getaffinity, CPU_COUNT, don't forget _GNU_SOURCE, check you're on a glibc system, probably check at runtime too, so use dlsym to access s

Re: RFR 4823133: RandomAccessFile.length() is not thread-safe

2015-12-15 Thread Martin Buchholz
_FILE_OFFSET_BITS is generally an all-or-nothing thing, because it affects interoperability between translation units. It would be good to convert all of the JDK build to use -D_FILE_OFFSET_BITS=64, but that would be a big job. So traditionally the JDK has instead used the functions made availabl

Re: RFR: JDK-8115868: 32-bit JVM failed to start from a large network filesystem

2015-12-15 Thread Martin Buchholz
Note that the semantics of stat and access may be subtly different, and that there are many calls to stat in the JDK sources, and they may all be broken on 32-bit systems. I just wrote elsewhere: _FILE_OFFSET_BITS is generally an all-or-nothing thing, because it affects interoperability between t

Re: RFR(xs): 8145427: [aix] xlc: wrong flag used to switch off optimization

2015-12-15 Thread David Holmes
Hi Thomas, This kind of thing goes to build-dev (cc'd) not jdk9-dev (which doesn't take code reviews). I've Reviewed this, and as it is a trivial change, and we're going to put it into hs-rt forest, I will sponsor it for you. Thanks, David On 16/12/2015 3:22 AM, Thomas Stüfe wrote: Hi all

Re: RFR(xs): 8145427: [aix] xlc: wrong flag used to switch off optimization

2015-12-15 Thread Thomas Stüfe
Hi David, thank you! ..Thomas On Wed, Dec 16, 2015 at 7:21 AM, David Holmes wrote: > Hi Thomas, > > This kind of thing goes to build-dev (cc'd) not jdk9-dev (which doesn't > take code reviews). > > I've Reviewed this, and as it is a trivial change, and we're going to put > it into hs-rt forest