OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Mani Sarkar
Hi all, Whilst build OpenJDK (latest version from http://hg.openjdk.java.net/jdk8u/jdk8u/), we have noticed, that the build system does not make use of all the CPU cores available on the machine even though it detects them all. (see snippets from the build log below) Detects *4 cores* checking

Fwd: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Mani Sarkar
+adoption-disc...@openjdk.java.net to the discussion -- Forwarded message - From: Mani Sarkar Date: Wed, 19 Apr 2017 at 08:42 Subject: OpenJDK ARM build not using all the CPU cores To: build-dev@openjdk.java.net , build-infra-...@openjdk.java.net Hi all, Whilst build OpenJDK

Re: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Andrew Haley
On 19/04/17 08:42, Mani Sarkar wrote: > Whilst build OpenJDK (latest version from > http://hg.openjdk.java.net/jdk8u/jdk8u/), we have noticed, that the build > system does not make use of all the CPU cores available on the machine even > though it detects them all. It's because you have almost no

Re: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Mani Sarkar
Thanks Andrew for clarifying. On Wed, 19 Apr 2017 at 08:56 Andrew Haley wrote: > On 19/04/17 08:42, Mani Sarkar wrote: > > Whilst build OpenJDK (latest version from > > http://hg.openjdk.java.net/jdk8u/jdk8u/), we have noticed, that the > build > > system does not make use of all the CPU cores a

Re: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Ioi Lam
If you really want, you can override the settings with make JOBS=4 images Of course, YMMV due to the low amount of memory. Ioi > Mani Sarkar 於 2017年4月19日 下午4:07 寫道: > > Thanks Andrew for clarifying. > >> On Wed, 19 Apr 2017 at 08:56 Andrew Haley wrote: >> >>> On 19/04/17 08:42, Mani Sarkar

Re: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Erik Joelsson
If you want to do the override at configure time, the correct configure parameter is --with-jobs=4. The --with-num-cores isn't all that useful except for easier testing of the logic for calculating the default number of jobs (which is why I left it there). The default limitation of jobs based

Re: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Mani Sarkar
Thanks Erik, I have updated our scripts with this flag. Cheers, Mani On Wed, 19 Apr 2017 at 10:29 Erik Joelsson wrote: > If you want to do the override at configure time, the correct configure > parameter is --with-jobs=4. The --with-num-cores isn't all that useful > except for easier testing o

Re: Please review: JDK-8178725: provide way to link to external documentation

2017-04-19 Thread Magnus Ihse Bursie
On 2017-04-18 19:44, Kumar Srinivasan wrote: Hello, As explained in the JBS issue [1], this new taglet enables API documents to contain the extLink tag to link external sources. Please review the webrev [2]. Changes looks good. Just a reflection: This is heavily biased to Oracle documentation

RFR: JDK-8178438 Info-privileged.plist claims launchers to be "OpenJDK 7 Command"

2017-04-19 Thread Magnus Ihse Bursie
The file src/java.base/macosx/native/launcher/Info-privileged.plist, which is used when building signed macos launcher binaries, contains this snippet: CFBundleName OpenJDK 7 Command I assume this has not been updated since JDK 7. I suggest removing the version number from the

Re: RFR: JDK-8178438 Info-privileged.plist claims launchers to be "OpenJDK 7 Command"

2017-04-19 Thread Erik Joelsson
Looks good. /Erik On 2017-04-19 13:42, Magnus Ihse Bursie wrote: The file src/java.base/macosx/native/launcher/Info-privileged.plist, which is used when building signed macos launcher binaries, contains this snippet: CFBundleName OpenJDK 7 Command I assume this has not been

RFR: JDK-8178042 Allow custom taglets

2017-04-19 Thread Magnus Ihse Bursie
Please review this simple change to allow custom to add specialized javadoc taglets. Bug: https://bugs.openjdk.java.net/browse/JDK-8178042 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8178042-allow-custom-taglets/webrev.01 /Magnus

Re: Please review: JDK-8178725: provide way to link to external documentation

2017-04-19 Thread David Holmes
On 19/04/2017 9:26 PM, Magnus Ihse Bursie wrote: On 2017-04-18 19:44, Kumar Srinivasan wrote: Hello, As explained in the JBS issue [1], this new taglet enables API documents to contain the extLink tag to link external sources. Please review the webrev [2]. Changes looks good. Just a reflecti

RFR: JDK-8178038, JDK-8178039, JDK-8178316 Javadoc specs directory

2017-04-19 Thread Magnus Ihse Bursie
This patch will solve three issues that I (unfortunately) filed as separate issues, but that shares a common solution. The three issues are: JDK-8178038 Copy jdwp-protocol.html to proper location JDK-8178039 Copy jvmti.html to proper location JDK-8178316 Add JVM-MANAGEMENT-MIB.mib to jdk/src/

RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

2017-04-19 Thread Magnus Ihse Bursie
With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no longer included in the generated documentation. The information provided by that file should move to src/jdk.jdi/share/classes/module-info.java instead. I also took the liberty of removing a bunch of other overview.ht

Re: RFR: JDK-8178038, JDK-8178039, JDK-8178316 Javadoc specs directory

2017-04-19 Thread Erik Joelsson
Looks good. Nit: Javadoc.gmk:358-360 only indented 2 spaces for continuation. Same goes for 390-393, but you didn't actually touch those lines. /Erik On 2017-04-19 14:36, Magnus Ihse Bursie wrote: This patch will solve three issues that I (unfortunately) filed as separate issues, but that s

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

2017-04-19 Thread Alan Bateman
On 19/04/2017 13:54, Magnus Ihse Bursie wrote: With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no longer included in the generated documentation. The information provided by that file should move to src/jdk.jdi/share/classes/module-info.java instead. I also took the

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

2017-04-19 Thread Erik Joelsson
Looks good to me. /Erik On 2017-04-19 14:54, Magnus Ihse Bursie wrote: With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no longer included in the generated documentation. The information provided by that file should move to src/jdk.jdi/share/classes/module-info.java

Re: RFR: JDK-8178438 Info-privileged.plist claims launchers to be "OpenJDK 7 Command"

2017-04-19 Thread Tim Bell
Looks good to me as well. Tim On 04/19/17 04:46, Erik Joelsson wrote: Looks good. /Erik On 2017-04-19 13:42, Magnus Ihse Bursie wrote: The file src/java.base/macosx/native/launcher/Info-privileged.plist, which is used when building signed macos launcher binaries, contains this snippet:

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

2017-04-19 Thread Mandy Chung
> On Apr 19, 2017, at 5:54 AM, Magnus Ihse Bursie > wrote: > > With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no > longer included in the generated documentation. The information provided by > that file should move to src/jdk.jdi/share/classes/module-info.java inste

Re: RFR: JDK-8178042 Allow custom taglets

2017-04-19 Thread Mandy Chung
> On Apr 19, 2017, at 4:57 AM, Magnus Ihse Bursie > wrote: > > Please review this simple change to allow custom to add specialized javadoc > taglets. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8178042 > WebRev: > http://cr.openjdk.java.net/~ihse/JDK-8178042-allow-custom-taglets/webrev

Re: Please review: JDK-8178725: provide way to link to external documentation

2017-04-19 Thread Kumar Srinivasan
Have made the following changes: * fixed the indentations, basically pointed the IDE and asked it to reformat the whole file * fixed regex, to be defensive against leading WS, though the DocCommentParser whacks the WS. Please see updated webrev: http://cr.openjdk.java.net/~ksrini/8178725

Re: Please review: JDK-8178725: provide way to link to external documentation

2017-04-19 Thread Kumar Srinivasan
We could potentially make the default URL to be "some" cgi url, and have the build system specify the URL all the time, in our case it would be the Oracle documentation URL. Would this be an acceptable approach ? Kumar On 19/04/2017 9:26 PM, Magnus Ihse Bursie wrote: On 2017-04-18 19:44, Ku

Re: OpenJDK ARM build not using all the CPU cores

2017-04-19 Thread Mani Sarkar
Thanks Erik we applied that flag and it has picked up the cores, we wll see when the build finishes how much or how long it took to finish compared to our previous 1-3 hour builds. On Wed, 19 Apr 2017 at 11:09 Mani Sarkar wrote: > Thanks Erik, I have updated our scripts with this flag. > > Cheer

Re: Please review: JDK-8178725: provide way to link to external documentation

2017-04-19 Thread David Holmes
On 20/04/2017 3:50 AM, Kumar Srinivasan wrote: We could potentially make the default URL to be "some" cgi url, and have the build system specify the URL all the time, in our case it would be the Oracle documentation URL. Would this be an acceptable approach ? I'm not sure what you mean. I ha

Re: Please review: JDK-8178725: provide way to link to external documentation

2017-04-19 Thread Kumar Srinivasan
On 4/19/2017 1:37 PM, David Holmes wrote: On 20/04/2017 3:50 AM, Kumar Srinivasan wrote: We could potentially make the default URL to be "some" cgi url, and have the build system specify the URL all the time, in our case it would be the Oracle documentation URL. Would this be an acceptable a

Re: RFR: JDK-8178038, JDK-8178039, JDK-8178316 Javadoc specs directory

2017-04-19 Thread Mandy Chung
> On Apr 19, 2017, at 5:36 AM, Magnus Ihse Bursie wrote: > > WebRev: http://cr.openjdk.java.net/~ihse/JDK-8178038-javadoc-specs/webrev.01 368 JDWP_PROTOCOL := $(SUPPORT_OUTPUTDIR)/gensrc/jdk.jdi/jdwp-protocol.html 369 $(eval $(call SetupCopyFiles, COPY_JDWP_PROTOCOL, \ 370 FILES := $(JDWP

Re: RFR: JDK-8178038, JDK-8178039, JDK-8178316 Javadoc specs directory

2017-04-19 Thread Mandy Chung
> On Apr 19, 2017, at 3:54 PM, Mandy Chung wrote: > > >> On Apr 19, 2017, at 5:36 AM, Magnus Ihse Bursie wrote: >> >> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8178038-javadoc-specs/webrev.01 > > 368 JDWP_PROTOCOL := $(SUPPORT_OUTPUTDIR)/gensrc/jdk.jdi/jdwp-protocol.html One more thing: j

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

2017-04-19 Thread David Holmes
On 19/04/2017 10:54 PM, Magnus Ihse Bursie wrote: With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no longer included in the generated documentation. The information provided by that file should move to src/jdk.jdi/share/classes/module-info.java instead. Looks good, but