Re: JDK 10 RFR of JDK-8193208: Add additional licensing file for the JDK

2017-12-14 Thread Erik Joelsson
Hello, Adding build-dev. Here is a webrev with this file and the necessary build changes to make it end up in the built images. http://cr.openjdk.java.net/~erikj/8193208/webrev.jdk10.01/ /Erik On 2017-12-14 06:56, joe darcy wrote: Hello, FYI, please review the ADDITIONAL_LICENSE_INFO file

8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Alan Bateman
Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but the build still creates a launcher that is now DOA with "Error: Could not find or load main class com.sun.tools.javah.Main in module jdk.compiler". This is caught by one of the launcher tests that checks the option

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Erik Joelsson
Looks good! /Erik On 2017-12-14 10:12, Alan Bateman wrote: Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but the build still creates a launcher that is now DOA with "Error: Could not find or load main class com.sun.tools.javah.Main in module jdk.compiler". This

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread joe darcy
On 12/14/2017 1:12 AM, Alan Bateman wrote: Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but the build still creates a launcher that is now DOA with "Error: Could not find or load main class com.sun.tools.javah.Main in module jdk.compiler". This is caught by one

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-14 Thread Erik Joelsson
On 2017-12-14 05:40, David Holmes wrote: On 14/12/2017 1:51 PM, [email protected] wrote: I just went through this for the versioning changes.  The attached patch (against d2a837cf9ff1) does what you want, I think. We can't do that. src/java.base/share/native/include/classfile_constant

Proposal: make/Main.gmk Add extra extension/override points to the make file

2017-12-14 Thread Steve Groeger
Hi, I would like to propose the changes below to allow the make/Main.gmk file to be more extensible. These changes will allow an extension make file to be able to extend or override certain variable and targets. I would appreciate any feedback. I would also like to find out how I go about

Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2017-12-14 Thread Erik Joelsson
Hello Steve, It's certainly an interesting test of the existing extension points when someone else needs to use them. The use case of replacing hotspot completely is definitely new to me. First of all, Main.gmk only contains one call to IncludeCustomExtension close to the beginning of the fi

Re: JDK 10 RFR of JDK-8193208: Add additional licensing file for the JDK

2017-12-14 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 14 dec. 2017 kl. 09:12 skrev Erik Joelsson : > > Hello, > > Adding build-dev. Here is a webrev with this file and the necessary build > changes to make it end up in the built images. > > http://cr.openjdk.java.net/~erikj/8193208/webrev.jdk10.01/ > > /Erik > >> O

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-14 Thread Erik Joelsson
And here it is: http://cr.openjdk.java.net/~erikj/8173382/webrev.01/ Feel free to incorporate this into whichever changeset you want, or I can push this separately. /Erik On 2017-12-14 10:37, Erik Joelsson wrote: On 2017-12-14 05:40, David Holmes wrote: On 14/12/2017 1:51 PM, mark.reinh..

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Alan Bateman
On 14/12/2017 09:21, Erik Joelsson wrote: Looks good! /Erik I'll get this in now and also create another issue to remove the other remnants of javah from the build (they won't impact the build output but will need to be cleaned up). -Alan

Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2017-12-14 Thread Steve Groeger
Erik, Thank you very much for you very constructive comments. We do have our own JVM (OpenJ9) which does replace hotspot and which these proposed changes are attempting to implement with as minimal changes needed within the OpenJDK code as possible. I will attempt to implement some of your

Re: JDK 10 RFR of JDK-8193208: Add additional licensing file for the JDK

2017-12-14 Thread Tim Bell
Erik, Joe: Hello, Adding build-dev. Here is a webrev with this file and the necessary build changes to make it end up in the built images. http://cr.openjdk.java.net/~erikj/8193208/webrev.jdk10.01/ /Erik On 2017-12-14 06:56, joe darcy wrote: Hello, FYI, please review the ADDITIONAL_LICENSE

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-14 Thread Paul Sandoz
> On 14 Dec 2017, at 03:58, Erik Joelsson wrote: > > And here it is: http://cr.openjdk.java.net/~erikj/8173382/webrev.01/ > > Feel free to incorporate this into whichever changeset you want, or I can > push this separately. > Thanks! that is exactly what i was looking for. I will merge it i

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-14 Thread Paul Sandoz
> On 13 Dec 2017, at 19:51, [email protected] wrote: > > 2017/12/13 15:49:53 -0800, [email protected]: >> On 13 Dec 2017, at 14:36, [email protected] wrote: >>> I understand that other incoming changes are waiting for the 11 version >>> bump, but can't we at least do the strai

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Jonathan Gibbons
Alan, Thanks for catching and handling this. Sorry for the scramble. I'm surprised it wasn't caught by the jdk-tier1 tests I ran before pushing the changeset. -- Jon On 12/14/2017 01:12 AM, Alan Bateman wrote: Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but