Re: RFR: build pragma error with gcc 4.4.7

2018-03-20 Thread Michal Vala
On 03/20/2018 12:23 AM, Kim Barrett wrote: Given that there seem to be no callers of os::readdir that share the DIR* among multiple threads, it would seem easier to just replace the use of ::readdir_r with ::readdir. That seems to be the intent in the deprecation decision; use ::readdir, and

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-20 Thread Magnus Ihse Bursie
On 2018-03-16 19:12, Magnus Ihse Bursie wrote: Hi Sundar, I almost missed your mail, since you removed both me and build-dev from the cc list... 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan : Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either use /proc

[XXS] 8199858 : solaris-x86_64 : unpack200 fails linking with SS12u4

2018-03-20 Thread Baesken, Matthias
Hello , could you please review this small fix for Solaris x86_64 ? We were running into build errors for unpack200 on Solaris x86_64 because of missing symbol "environ" . The patch adds environ to the mapfile . ( seems this is a similar / same problem already solved for Solaris S

Re: RFR: 8199138: Add RISC-V support to Zero

2018-03-20 Thread Edward Nevill
On Tue, 2018-03-20 at 08:39 +0100, Erik Helin wrote: > Please review the following webrev > > > > Bugid: https://bugs.openjdk.java.net/browse/JDK-8199138 > > Webrev: http://cr.openjdk.java.net/~enevill/8199138/webrev.00 > >32 # First, filter out everything that doesn't begin with "aarch64-" >

Re: [XXS] 8199858 : solaris-x86_64 : unpack200 fails linking with SS12u4

2018-03-20 Thread Volker Simonis
Hi Matthias, the change looks good. Can you please also update the copyright year before pushing (no need for a new webrev). Thanks, Volker On Tue, Mar 20, 2018 at 2:12 PM, Baesken, Matthias wrote: > Hello , could you please review this small fix for Solaris x86_64 ? > > We were running into

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-20 Thread Sundararajan Athijegannathan
Hi, Sounds good - so long as we don't have scripts that depend on the old name. Or if those could be fixed... -Sundar On 20/03/18, 4:54 PM, Magnus Ihse Bursie wrote: On 2018-03-16 19:12, Magnus Ihse Bursie wrote: Hi Sundar, I almost missed your mail, since you removed both me and build-de

Re: [XXS] 8199858 : solaris-x86_64 : unpack200 fails linking with SS12u4

2018-03-20 Thread Erik Joelsson
Looks good. /Erik On 2018-03-20 06:12, Baesken, Matthias wrote: Hello , could you please review this small fix for Solaris x86_64 ? We were running into build errors for unpack200 on Solaris x86_64 because of missing symbol "environ" . The patch adds environ to the mapfile . ( se

RFR: JDK-8199884: JDK-8199749 broke build with make 3.81

2018-03-20 Thread Erik Joelsson
My consistency check in JDK-8199749 broke the build if using make 3.81. We use make 4.0 most of the time internally so I didn't test with older make versions. The typical error looks like this: lib/CompileLibjsig.gmk:92: *** /Users/erik/hg/jdk-make381/open/build/macosx-x86_64-normal-server-rel

Re: RFR: JDK-8199884: JDK-8199749 broke build with make 3.81

2018-03-20 Thread Tim Bell
Erik: My consistency check in JDK-8199749 broke the build if using make 3.81. We use make 4.0 most of the time internally so I didn't test with older make versions. The typical error looks like this: lib/CompileLibjsig.gmk:92: *** /Users/erik/hg/jdk-make381/open/build/macosx-x86_64-normal-serve