Re: build openjdk8 on ubuntu18.04.1

2018-10-25 Thread John Paul Adrian Glaubitz
Hi! Please run: apt build-dep openjdk-8 as root before you continue. If that doesn’t help, try with “openjdk-9”, “openjdk-10” or “openjdk-11”. Cheers, Adrian > On Oct 25, 2018, at 7:03 AM, Zonghai Shang wrote: > > Here is my config: > > Running generated-configure.sh > configure: Configura

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-10-25 Thread Kevin Rushforth
Andy added the a comment [1] to the JEP with the command line options. I'll format it and add it to the JEP itself soon, but until then you can see it in the comments to help you review it. The tests will come shortly (Andy can comment on the state of this). They will be a mix of automated tes

Re: build openjdk8 on ubuntu18.04.1

2018-10-25 Thread Aleksey Shipilev
On 10/25/2018 07:03 AM, Zonghai Shang wrote: > A new configuration has been successfully created in > /home/yiji/jvm/jdk8u/build/linux-x86_64-normal-server-fastdebug > using configure arguments '--enable-debug --with-extra-cflags > --with-extra-cxxflags'. This looks tad suspicious. Why there are n

Re: Cannot compile OpenJDK 11 (visual studio fail)

2018-10-25 Thread Erik Joelsson
I think we need to make this check less strict to allow for different languages. /Erik On 2018-10-24 22:44, Artur Khusainov wrote: I also reported this earlier. You should install English (US) language pack for Visual Studio. And maybe uninstall your current language pack. чт, 25 окт. 2018

Re: Cannot compile OpenJDK 11 (visual studio fail)

2018-10-25 Thread Erik Joelsson
Filed https://bugs.openjdk.java.net/browse/JDK-8212986 /Erik On 2018-10-25 09:30, Erik Joelsson wrote: I think we need to make this check less strict to allow for different languages. /Erik On 2018-10-24 22:44, Artur Khusainov wrote: I also reported this earlier. You should install Engli

RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Iris Clark
Hi. Please review changes to use "https" instead of "http" for links in the generated JavaDoc API pages: 8212994: Links to Oracle websites should use "https:" bug: https://bugs.openjdk.java.net/browse/JDK-8212994 webrev: https://cr.openjdk.java.net/~iris/8212994/webrev/ I did a

Re: RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Erik Joelsson
Looks good. /Erik On 2018-10-25 13:33, Iris Clark wrote: Hi. Please review changes to use "https" instead of "http" for links in the generated JavaDoc API pages: 8212994: Links to Oracle websites should use "https:" bug: https://bugs.openjdk.java.net/browse/JDK-8212994 we

Re: RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Lance Andersen
+1 > On Oct 25, 2018, at 4:33 PM, Iris Clark wrote: > > Hi. > > Please review changes to use "https" instead of "http" for links in the > generated JavaDoc API pages: > > 8212994: Links to Oracle websites should use "https:" > bug: https://bugs.openjdk.java.net/browse/JDK-8212994 >

RFR: JDK-8213005: Missing symbols in hs_err files on Windows after JDK-8212028

2018-10-25 Thread Erik Joelsson
When running tests through the new RunTest makefile framework in Mach5, we are now missing symbol information in hs_err files on Windows. This is caused by the new run-test-prebuilt target not properly setting up _NT_SYMBOL_PATH which in turn is caused by the variable CYGPATH not being set. T

Re: RFR: JDK-8213005: Missing symbols in hs_err files on Windows after JDK-8212028

2018-10-25 Thread Christian Tornqvist
Hi Erik, This looks good, thanks for fixing this! Thanks, Christian > On Oct 25, 2018, at 4:27 PM, Erik Joelsson wrote: > > When running tests through the new RunTest makefile framework in Mach5, we > are now missing symbol information in hs_err files on Windows. This is caused > by the new

Re: RFR: JDK-8213005: Missing symbols in hs_err files on Windows after JDK-8212028

2018-10-25 Thread David Holmes
Hi Erik, Thanks for jumping on this promptly and fixing it! On 26/10/2018 9:27 AM, Erik Joelsson wrote: When running tests through the new RunTest makefile framework in Mach5, we are now missing symbol information in hs_err files on Windows. This is caused by the new run-test-prebuilt target n

RE: RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Iris Clark
Hi, Lance and Erik. Thanks for the super-speedy reviews. Pushed. iris From: Lance Andersen Sent: Thursday, October 25, 2018 1:48 PM To: Iris Clark Cc: [email protected]; Jonathan Gibbons Subject: Re: RFR(XS): 8212994: Links to Oracle websites should use "https:" +1 On