Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-12-06 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.00/ IBM29626C charset is required for AIX default charset. Java cannot start because of java/lang/ExceptionInInitializerError on AIX ja_JP l

Re: RFR (round 5), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-06 Thread coleen . phillimore
http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/shenandoah-gc/src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp.html Can you rename these to shenandoahVMOperations.hpp/cpp to match the newly agreed upon naming convention for this? See 8214791: Consistently name gc files

Re: RFR (round 5), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-06 Thread Roman Kennke
Hi Coleen, > http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/shenandoah-gc/src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp.html > > > Can you rename these to shenandoahVMOperations.hpp/cpp to match the > newly agreed upon naming convention for this? > > See 8214791: Cons

Re: bootcycle builds x86_64-linux-gnu?

2018-12-06 Thread Matthias Klose
On 04.12.18 14:54, Aleksey Shipilev wrote: > On 12/4/18 2:24 PM, Matthias Klose wrote: >> with jdk-12+22, bootcycle builds fail at least on x86_64-linux-gnu. Is there >> some place where I can check if this kind of build succeeds for others? > > Just did this on jdk/jdk tip, and it passed: > >

Re: bootcycle builds x86_64-linux-gnu?

2018-12-06 Thread Aleksey Shipilev
On 12/6/18 4:34 PM, Matthias Klose wrote: > my bad, that happens in the test-image target: > > In the build log I see: > > FindJtregGroups /home/packages/openjdk/12/openjdk-12-12~23/test/jdk > FindJtregGroups /home/packages/openjdk/12/openjdk-12-12~23/test/langtools > FindJtregGroups /home/packag

Re: bootcycle builds x86_64-linux-gnu?

2018-12-06 Thread Matthias Klose
On 06.12.18 17:41, Aleksey Shipilev wrote: > On 12/6/18 4:34 PM, Matthias Klose wrote: >> my bad, that happens in the test-image target: >> >> In the build log I see: >> >> FindJtregGroups /home/packages/openjdk/12/openjdk-12-12~23/test/jdk >> FindJtregGroups /home/packages/openjdk/12/openjdk-12-12

Re: bootcycle builds x86_64-linux-gnu?

2018-12-06 Thread Erik Joelsson
Could you insert this before line 1087 in make/Main.gmk and post the output? $(call PrintVar, ALL_NAMED_TESTS) /Erik On 2018-12-06 10:31, Matthias Klose wrote: On 06.12.18 17:41, Aleksey Shipilev wrote: On 12/6/18 4:34 PM, Matthias Klose wrote: my bad, that happens in the test-image target:

Re: bootcycle builds x86_64-linux-gnu?

2018-12-06 Thread Matthias Klose
On 06.12.18 20:04, Erik Joelsson wrote: > Could you insert this before line 1087 in make/Main.gmk and post the output? > > $(call PrintVar, ALL_NAMED_TESTS) > > /Erik > > On 2018-12-06 10:31, Matthias Klose wrote: >> On 06.12.18 17:41, Aleksey Shipilev wrote: >>> On 12/6/18 4:34 PM, Matthias Klo

Re: bootcycle builds x86_64-linux-gnu?

2018-12-06 Thread Erik Joelsson
Nothing strange in there. Is it only printed once? I wouldn't be surprised if this got printed more than one time during a normal make execution (due to reloads caused by -include). If it is, then perhaps there is something different in a later print? /Erik On 2018-12-06 11:23, Matthias Klose

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-06 Thread Ali İnce
Hi Magnus, Alexey, I believe we won’t be able to get further opinions from serviceability-dev. Andrew Luo suggested using a similar mechanism as is used for jvm.dll by using symbol name files mapped by platform (files are under make/hotspot/symbols and interestingly windows is almost the only p