Hi Erik, here is the updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8130017.2/
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Freitag, 10. Mai 2019 16:29
> To: Baesken, Matthias ; David Holmes
> ; '[email protected]' [email protected]
Looks good, thanks!
/Erik
On 2019-05-14 03:16, Baesken, Matthias wrote:
Hi Erik, here is the updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8130017.2/
Best regards, Matthias
-Original Message-
From: Erik Joelsson
Sent: Freitag, 10. Mai 2019 16:29
To: Baesken, Matth
Thanks !
May I have a second review ?
Btw I added a comment to
https://bugs.openjdk.java.net/browse/JDK-8130017
describing a bit the "current situation" (minimum gcc 4.8 +
"-U_FORTIFY_SOURCE" for lower level OPT-flags (< -O1) ) .
Best regards, Matthias
>
> Looks good, thanks!
>
Hello, I checked the zlib config settings and found the following :
make/autoconf/lib-bundled.m4 states :
# Setup bundled libraries.
#
# For libjpeg, giflib, libpng, lcms2 and zlib, the source is present in the
# O
On 14/05/2019 15:58, Baesken, Matthias wrote:
:
On the other OS platforms, in case a zlib is found on the system :
if test "x${ZLIB_FOUND}" != "xyes"; then
# If we don't find any system...set default to bundled
DEFAULT_ZLIB=bundled
fi
we use it from the system .
Wouldn't it be
Hi Goetz,
Thanks for raising this issue.
I'm not surprised by MaxAdvanceIsMax test failing on some OS. The reason
is that this test is very OS specific.
All installed fonts are tested and a static value from each font is used
for the assertion, after scale calculations. If there is a difference
Hi Goetz,
On 5/13/19 1:38 PM, Lindenmaier, Goetz wrote:
>
> Can I somehow verify that it's the font that has the problem?
> Can I fix the font so that the test passes?
>
I cannot say whether or not the static max advance value in each font is
right or not, but let's assume it is. The underlying
