Erik:
Looks good.
Tim
This is a fix for a problem brought up on this list [1]. The main issue
is that when cross compiling, and creating a buildjdk during the build,
the UnixConstants.java cannot necessarily be reused between the target
JDK and the buildjdk. While investigating this, I came to
Thanks!
During testing, I found an intermittent race issue. The command line
that runs the interim langtools version of javac still always points to
the buildtools/interim-langtools dir of the normal build. This variable
also needs to be rewritten in buildjdk-spec.gmk.in. New webrev, only
cha
Hi. Thank for your recomendation!
Although I did not success to run "hg update -r jdk-11.0.2-ga" - got :
"abort: no repository found in '/cygdrive/c/jdk11u-11.0.2-ga' (.hg not
found)!"
But since I from begining cloned jdk-11.0.2 label form site - I suppose it
gives equavalent result.
And finally I
Hello,
Please review this fix for the default CDS classlist generation. This
patch adds an explicit English locale to the generation command to make
the build less dependent on the locale it is running in, and produce the
same classlist regardless.
Thanks to Ioi who helped me verify that the
On 5/06/2019 2:20 am, Moshe Zuisman wrote:
Hi. Thank for your recomendation!
Although I did not success to run "hg update -r jdk-11.0.2-ga" - got :
"abort: no repository found in '/cygdrive/c/jdk11u-11.0.2-ga' (.hg not
found)!"
I don't know how you are "cloning" things but you are not getting
Looks good! Thanks for the patch.
Ioi
> On Jun 4, 2019, at 2:53 PM, Erik Joelsson wrote:
>
> Hello,
>
> Please review this fix for the default CDS classlist generation. This patch
> adds an explicit English locale to the generation command to make the build
> less dependent on the locale it
Erik:
OK - version 2 looks good.
Tim
Thanks!
During testing, I found an intermittent race issue. The command line
that runs the interim langtools version of javac still always points to
the buildtools/interim-langtools dir of the normal build. This variable
also needs to be rewritten in buil
Erik:
Looks good to me as well.
Tim
On 06/04/19 16:59, Ioi Lam wrote:
Looks good! Thanks for the patch.
Ioi
On Jun 4, 2019, at 2:53 PM, Erik Joelsson wrote:
Hello,
Please review this fix for the default CDS classlist generation. This patch
adds an explicit English locale to the generati
Hi Erik,
Thank you a lot for taking care of this. I mainly like your approach.
I tested the patch by cross building mips64-zero, by which we found
this problem. However, it seems the problem still exists. The reason I
found is that UnixConstants.java of buildjdk is generated by cross
compiler, so
