RE: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk images

2020-02-07 Thread Baesken, Matthias
Hello, here is a slightly changed new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8237192.4/ (adjusted $(JRE_STRIPPED_PDB_FILES) in Bundles.gmk, that was in the wrong place ) . > I think it needs to be a separate option as it's all orthogonal to the > main debug symbols file cre

RFR: JDK-8238534

2020-02-07 Thread René Schünemann
For the Apple notarization process, the whole bundle in its final form has to be signed with the codesign tool. See the discussion here: https://bugs.openjdk.java.net/browse/JDK-8238225 This change copies all JDK/JRE files to a temporary directory, which is then passed to the codesign tool. The te

Re: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk images

2020-02-07 Thread Magnus Ihse Bursie
On 2020-02-07 09:50, Baesken, Matthias wrote: Hello, here is a slightly changed new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8237192.4/ In Bundles.gmk, this line: $(ECHO) found stripped pdb file {f}, we rename it to: {f%stripped.pdb}pdb; \ It looks almost like left-o

Re: RFR: JDK-8238534

2020-02-07 Thread Erik Joelsson
Hello René, It's good to see an open solution to this, but I have some opinions on the patch. The concept of building into "temp dirs" that are then removed is a practice we try to avoid in the build. Whenever possible, each rule should be a well defined transformation from a set of source f

ARM build broken?

2020-02-07 Thread Marc Hoffmann
Dear JDK developers, it looks like building http://hg.openjdk.java.net/jdk/jdk/ in ARM is broken since yesterday. This commit seems to be the first one that broke the build: changeset: 57948:4a4d185098e2 tag: tip user:lfoltan date:T

Re: ARM build broken?

2020-02-07 Thread Erik Joelsson
Adding hotspot-dev since this is caused by a source change in hotspot and not really a build issue. We see it in our internal arm builds as well. /Erik On 2020-02-07 13:38, Marc Hoffmann wrote: Dear JDK developers, it looks like building http://hg.openjdk.java.net/jdk/jdk/

Re: ARM build broken?

2020-02-07 Thread David Holmes
Hi, It is a known breakage: https://bugs.openjdk.java.net/browse/JDK-8238643 David On 8/02/2020 7:49 am, Erik Joelsson wrote: Adding hotspot-dev since this is caused by a source change in hotspot and not really a build issue. We see it in our internal arm builds as well. /Erik On 2020-02-0