RFR: JDK-8242463: ProcessTools.createNativeTestProcessBuilder() in testlib needs jdk/bin on PATH on Windows

2020-04-09 Thread Erik Joelsson
The test open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java fails when building the JDK with VS2019. More specifically, it fails if the JDK under test is built with a different version of VS than the boot JDK. The cause of this is in how the PATH is setup. Process

Re: RFR: JDK-8242463: ProcessTools.createNativeTestProcessBuilder() in testlib needs jdk/bin on PATH on Windows

2020-04-09 Thread mikhailo . seledtsov
Hi Erik,   Looks good to me. Thanks for fixing this. Misha On 4/9/20 8:15 AM, Erik Joelsson wrote: The test open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java fails when building the JDK with VS2019. More specifically, it fails if the JDK under test is built wit

Re: RFR: JDK-8242463: ProcessTools.createNativeTestProcessBuilder() in testlib needs jdk/bin on PATH on Windows

2020-04-09 Thread Igor Ignatyev
Hi Erik, looks good to me. -- Igor > On Apr 9, 2020, at 8:15 AM, Erik Joelsson wrote: > > The test > open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java > fails when building the JDK with VS2019. More specifically, it fails if the > JDK under test is built with a

Re: RFR: JDK-8242463: ProcessTools.createNativeTestProcessBuilder() in testlib needs jdk/bin on PATH on Windows

2020-04-09 Thread Tim Bell
Erik: Looks good to me as well. Tim The test open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java fails when building the JDK with VS2019. More specifically, it fails if the JDK under test is built with a different version of VS than the boot JDK. The cause of t

RFR: JDK-8242468: VS2019 build missing vcruntime140_1.dll

2020-04-09 Thread Erik Joelsson
When building with VS2019, there is a new runtime library, vcruntime140_1.dll, that we need to bundle along with the others. This patch sets this up all through the build. Bug: https://bugs.openjdk.java.net/browse/JDK-8242468 Webrev: http://cr.openjdk.java.net/~erikj/8242468/webrev.01/index.ht

Re: RFR: JDK-8242468: VS2019 build missing vcruntime140_1.dll

2020-04-09 Thread Tim Bell
Erik: Looks good. When building with VS2019, there is a new runtime library, vcruntime140_1.dll, that we need to bundle along with the others. This patch sets this up all through the build. Bug: https://bugs.openjdk.java.net/browse/JDK-8242468 Webrev: http://cr.openjdk.java.net/~erikj/82424