On 2020-05-13 19:48, Erik Joelsson wrote:
As was pointed out by Adrián Ruiz Arroyo, when signing our macosx
builds with hardened runtime enabled, we are currently missing the
entitlement for using the microphone. This patch is correcting that.
It would be good if I could get help verifying that
On 2020-05-13 16:04, Erik Joelsson wrote:
When updating the Windows toolchain at Oracle, I forgot to also mark
the new toolchain VS2019 as supported in configure. This has the
effect that configuring with VS2019 causes a warning to be printed.
We should also make configure prefer 2019 over 201
The compare script has had a lot of exceptions for files that were not
possible to build reproducibly. Many of these has now been fixed, and
the exceptions can be removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245032
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8245032-clean-up-compar
On 2020-05-14 16:05, Magnus Ihse Bursie wrote:
The compare script has had a lot of exceptions for files that were not
possible to build reproducibly. Many of these has now been fixed, and
the exceptions can be removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245032
WebRev:
http://cr.op
Here's a bunch of minor fixes to improve developer experience when
building on WSL.
The fixes include:
* Now the FixPath macro works for WSL.
* TestImage.gmk tried to use FIXPATH for /bin/echo, does not work on WSL
* Use -t drvfs option to df to properly detect a suitable local disk
to build
On 2020-05-14 07:23, Magnus Ihse Bursie wrote:
On 2020-05-14 16:05, Magnus Ihse Bursie wrote:
The compare script has had a lot of exceptions for files that were
not possible to build reproducibly. Many of these has now been fixed,
and the exceptions can be removed.
Bug: https://bugs.openjdk.j
On 2020-05-14 07:45, Magnus Ihse Bursie wrote:
Here's a bunch of minor fixes to improve developer experience when
building on WSL.
The fixes include:
* Now the FixPath macro works for WSL.
* TestImage.gmk tried to use FIXPATH for /bin/echo, does not work on WSL
* Use -t drvfs option to df
On 2020-05-14 18:23, Erik Joelsson wrote:
On 2020-05-14 07:45, Magnus Ihse Bursie wrote:
Here's a bunch of minor fixes to improve developer experience when
building on WSL.
The fixes include:
* Now the FixPath macro works for WSL.
* TestImage.gmk tried to use FIXPATH for /bin/echo, does not
Looks good.
/Erik
On 2020-05-14 09:42, Magnus Ihse Bursie wrote:
On 2020-05-14 18:23, Erik Joelsson wrote:
On 2020-05-14 07:45, Magnus Ihse Bursie wrote:
Here's a bunch of minor fixes to improve developer experience when
building on WSL.
The fixes include:
* Now the FixPath macro works fo
On 2020-05-14 18:02, Erik Joelsson wrote:
On 2020-05-14 07:23, Magnus Ihse Bursie wrote:
On 2020-05-14 16:05, Magnus Ihse Bursie wrote:
The compare script has had a lot of exceptions for files that were
not possible to build reproducibly. Many of these has now been
fixed, and the exceptions ca
In configure, it's imperative that you pair an AC_CHECKING with an
AC_RESULT, before you do any other output. This patch fixes two places
where this was not done.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245041
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8245041-fix-AC_RESULT-wrong/webr
Looks good.
/Erik
On 2020-05-14 09:57, Magnus Ihse Bursie wrote:
In configure, it's imperative that you pair an AC_CHECKING with an
AC_RESULT, before you do any other output. This patch fixes two places
where this was not done.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245041
WebRev:
h
Separate from this RFR, jtreg supports WSL (or is supposed to!) and so I
wonder if you have looked at using WSL in the run-tests framework.
-- Jon
Looks good.
/Erik
On 2020-05-14 09:49, Magnus Ihse Bursie wrote:
On 2020-05-14 18:02, Erik Joelsson wrote:
On 2020-05-14 07:23, Magnus Ihse Bursie wrote:
On 2020-05-14 16:05, Magnus Ihse Bursie wrote:
The compare script has had a lot of exceptions for files that were
not possible to build re
The makefile for hotspot-ide-project resides in hotspot/ide, not ide.
(The old rule did cd make/hotspot && make -f ide/CreateVSProject.gmk,
but this got lost in translation.)
Bug: https://bugs.openjdk.java.net/browse/JDK-8245046
Patch inline:
diff --git a/make/Main.gmk b/make/Main.gmk
--- a/mak
Hi,
Please review:
bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524
webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/webrev-00/
Summary: After 8232069, CDS can create shared archive with
-XX:-UseCompressedOops which also turned off by ZGC. The build with cds
enabled
Looks good.
/Erik
On 2020-05-14 10:38, Magnus Ihse Bursie wrote:
The makefile for hotspot-ide-project resides in hotspot/ide, not ide.
(The old rule did cd make/hotspot && make -f ide/CreateVSProject.gmk,
but this got lost in translation.)
Bug: https://bugs.openjdk.java.net/browse/JDK-824504
Build changes look good.
/Erik
On 2020-05-14 10:40, Yumin Qi wrote:
Hi,
Please review:
bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524
webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/webrev-00/
Summary: After 8232069, CDS can create shared archive with
-XX:-UseCo
Hi, Erik
Thanks for review!
Yumin
On 5/14/20 10:57 AM, Erik Joelsson wrote:
Build changes look good.
/Erik
On 2020-05-14 10:40, Yumin Qi wrote:
Hi,
Please review:
bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524
webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/w
Hi Yumin,
Looks good to me. Just one small nit:
+ LogTarget(Info, cds) lt;
+ if (lt.is_enabled()) {
+ lt.print("trying to map %s", _full_path);
+ }
This can be simplified as
log_info(cds)("trying to map %s", _full_path);
NO need for updated webrev.
Thanks
- Ioi
On 5/14/20 10:40
Dear Rory, dear all,
JaCoCo project here. It looks like that OpenJDK build for jdk main dev branch
(Java 15) is broken for us on ARM32 since commit
changeset 59296:e25b21095e86
8242524: Use different default CDS archives depending on UseCompressOops
Reviewed-by: erikj, iklam, ccheun
Hi Marc,
I will file a bug for this. Thanks for the report.
David
On 15/05/2020 4:04 pm, Marc Hoffmann wrote:
Dear Rory, dear all,
JaCoCo project here. It looks like that OpenJDK build for jdk main dev branch
(Java 15) is broken for us on ARM32 since commit
changeset 59296:e25b21095e86
https://bugs.openjdk.java.net/browse/JDK-8245070
David
On 15/05/2020 4:10 pm, David Holmes wrote:
Hi Marc,
I will file a bug for this. Thanks for the report.
David
On 15/05/2020 4:04 pm, Marc Hoffmann wrote:
Dear Rory, dear all,
JaCoCo project here. It looks like that OpenJDK build for jdk
23 matches
Mail list logo
