Re: RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 22:00:32 GMT, Phil Race wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of C++

RFR: JDK-8260669: Missing quotes in fixpath.sh

2021-01-29 Thread Erik Joelsson
The build on Windows can fail if certain directory names are present in root directory of the workspace. In particular I've observed that the single letter 'p' is triggering this problem. This is caused by missing quotes around [:upper:] in a 'tr' call in fixpath.sh. - Commit

Re: RFR: JDK-8260669: Missing quotes in fixpath.sh

2021-01-29 Thread Tim Bell
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around

Re: RFR: JDK-8260669: Missing quotes in fixpath.sh

2021-01-29 Thread Iris Clark
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around

Re: RFR: JDK-8260669: Missing quotes in fixpath.sh

2021-01-29 Thread Mikael Vidstedt
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 14:57:56 GMT, Weijun Wang wrote: >> This fix covers both >> >> - [[macOS]: Remove JNF dependency from >> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) >> - [[macOS]: Remove JNF dependency from >>

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 21:47:32 GMT, Weijun Wang wrote: >> src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m line 619: >> >>> 617: (*env)->ReleaseCharArrayElements(env, passwordObj, >>> passwordChars, >>> 618: JNI_ABORT); >>> 619: } >> >> Although you

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v3]

2021-01-29 Thread Weijun Wang
> This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) Weijun Wang has

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Weijun Wang
On Fri, 29 Jan 2021 20:51:04 GMT, Phil Race wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> same behavior as before -- empty realm map > > make/modules/java.security.jgss/Lib.gmk line 84: > >> 82:

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-01-29 Thread Alexey Semenyuk
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++ code from app launcher. > At startup app launcher loads

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v2]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 16:23:20 GMT, Gerard Ziemski wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8260616: Removing remaining JNF dependencies in the java.desktop modul > >

RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Alexey Semenyuk
Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 The fix splits Linux app launcher in app launcher and launcher shared lib. App launcher is pure C and doesn't have C++ code. App launcher lib incorporates bulk of C++ code from app launcher. At startup app launcher loads launcher shared

Re: RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote: > Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++

Re: RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote: > Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > incorporates bulk of C++

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Weijun Wang
On Fri, 29 Jan 2021 22:05:21 GMT, Phil Race wrote: >> So I should remember how env was retrieved and only detach when it's from >> `AttachCurrentThreadAsDaemon`? In fact, in my test the plain `GetEnv` has >> never succeeded and it was always attached. > > Yes that is the idea. BTW which thread

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v3]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 22:47:52 GMT, Weijun Wang wrote: >> This fix covers both >> >> - [[macOS]: Remove JNF dependency from >> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) >> - [[macOS]: Remove JNF dependency from >>

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-01-29 Thread Alexander Matveev
On Fri, 29 Jan 2021 23:06:20 GMT, Alexey Semenyuk wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of

Re: RFR: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m

2021-01-29 Thread Magnus Ihse Bursie
On Thu, 28 Jan 2021 22:40:57 GMT, Phil Race wrote: > This removes the JNF dependency from the jdk.hotspot.agent module. > The macro expansions are the same as already used in the Java desktop module > - which actually uses a macro > still but there there are hundreds of uses. > The function of

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module

2021-01-29 Thread Magnus Ihse Bursie
On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote: > This completes the desktop module JNF removal > > * remove -framework JavaNativeFoundation from make files > > * remove #import from all > source files. If needed add import of JNIUtilities.h to get jni.h definitions > - better anyway

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module

2021-01-29 Thread erik . joelsson
On 2021-01-29 02:56, Magnus Ihse Bursie wrote: On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote: This completes the desktop module JNF removal * remove -framework JavaNativeFoundation from make files * remove #import from all source files. If needed add import of JNIUtilities.h to

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m

2021-01-29 Thread Erik Joelsson
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote: > This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from >

Re: RFR: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 10:01:42 GMT, Magnus Ihse Bursie wrote: >> This removes the JNF dependency from the jdk.hotspot.agent module. >> The macro expansions are the same as already used in the Java desktop module >> - which actually uses a macro >> still but there there are hundreds of uses. >>

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module

2021-01-29 Thread Gerard Ziemski
On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote: > This completes the desktop module JNF removal > > * remove -framework JavaNativeFoundation from make files > > * remove #import from all > source files. If needed add import of JNIUtilities.h to get jni.h definitions > - better anyway

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module

2021-01-29 Thread Gerard Ziemski
On Fri, 29 Jan 2021 16:57:09 GMT, Gerard Ziemski wrote: >> This completes the desktop module JNF removal >> >> * remove -framework JavaNativeFoundation from make files >> >> * remove #import from all >> source files. If needed add import of JNIUtilities.h to get jni.h >> definitions -

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v2]

2021-01-29 Thread Phil Race
> This completes the desktop module JNF removal > > * remove -framework JavaNativeFoundation from make files > > * remove #import from all > source files. If needed add import of JNIUtilities.h to get jni.h definitions > - better anyway since then it gets the current JDK ones not the ones

Integrated: JDK-8260518: Change default -mmacosx-version-min to 10.12

2021-01-29 Thread Erik Joelsson
On Wed, 27 Jan 2021 19:23:48 GMT, Erik Joelsson wrote: > To guarantee backwards compatible binaries on Macos, we use the option > -mmacosx-version-min. This is currently set to 10.9, which is a really > ancient version. I propose we bump this to 10.12, which is still a rather > conservative

RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m

2021-01-29 Thread Weijun Wang
This fix covers both - [[macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) - [[macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) - Commit

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m

2021-01-29 Thread Weijun Wang
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote: > This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from >

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Weijun Wang
> This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) Weijun Wang has

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v2]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 17:02:30 GMT, Gerard Ziemski wrote: >> Changes requested by gziemski (Committer). > > Lots of small changes you had to handle here. Thank you for doing it! I pushed a commit with the remaining -lframework ... removals in the desktop makefiles that I had somehow missed ...

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 10:53:42 GMT, Magnus Ihse Bursie wrote: >> This completes the desktop module JNF removal >> >> * remove -framework JavaNativeFoundation from make files >> >> * remove #import from all >> source files. If needed add import of JNIUtilities.h to get jni.h >> definitions -