Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-25 Thread Thomas Stuefe
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files

2022-01-25 Thread Christian Hagedorn
On Tue, 18 Jan 2022 13:19:39 GMT, Christian Hagedorn wrote: > When printing the native stack trace on Linux (mostly done for hs_err files), > it only prints the method with its parameters and a relative offset in the > method: > > Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-25 Thread Thomas Stuefe
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from GetModuleHandle("zip.dll"),

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-01-25 Thread Andrew Dinn
On Mon, 24 Jan 2022 17:07:54 GMT, Alan Hayward wrote: > check_return_address() is being a huge help here Yes, I appreciate that rejecting double signing is a good model.The surprise was solely a reflection of my limited understanding. > There's no obvious way to catch those issues. Ok, well i

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-01-25 Thread Andrew Dinn
On Mon, 24 Jan 2022 16:51:26 GMT, Alan Hayward wrote: >> src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 835: >> >>> 833: __ stp(rlocals, rcpool, Address(sp, 2 * wordSize)); >>> 834: >>> 835: __ protect_return_address(); >> >> Most of the changes to fix the tests look

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-25 Thread David Holmes
On 25/01/2022 7:14 pm, Thomas Stuefe wrote: src/hotspot/os/aix/libperfstat_aix.cpp line 2: 1: /* 2: * Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved. Is there a reason for this copyright addition? Just FYI that is an invalid copyright line for Oracle. There ar

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v2]

2022-01-25 Thread Andrew Haley
On Thu, 11 Nov 2021 18:15:08 GMT, Florian Weimer wrote: > > > > Am I right is saying that for Macos, all generated code is remapped RO > > > > before execution? > > > > > > > > > Ah, no, it seems the code cache is not RWX all the time as far as Java > > > threads are concerned. The Macos/AArc

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v9]

2022-01-25 Thread Andrew Haley
On Sat, 11 Dec 2021 09:30:32 GMT, Andrew Haley wrote: >> Ok, I think that's fine. How about on a non pac system allowing it for >> development only ? > > Maybe. Mind you, a lot of the time I'm looking at the output from production > systems. > From a rather philosophical point of view, I assume

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-01-25 Thread Andrew Haley
On Mon, 24 Jan 2022 15:56:06 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files

2022-01-25 Thread Erik Joelsson
On Tue, 18 Jan 2022 13:19:39 GMT, Christian Hagedorn wrote: > When printing the native stack trace on Linux (mostly done for hs_err files), > it only prints the method with its parameters and a relative offset in the > method: > > Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v15]

2022-01-25 Thread Erik Joelsson
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v9]

2022-01-25 Thread Alan Hayward
On Tue, 25 Jan 2022 13:41:38 GMT, Andrew Haley wrote: >> Maybe. Mind you, a lot of the time I'm looking at the output from production >> systems. >> From a rather philosophical point of view, I assume that if the user of a >> computer asks for something that isn't going to break anything or con

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-25 Thread Christian Hagedorn
> When printing the native stack trace on Linux (mostly done for hs_err files), > it only prints the method with its parameters and a relative offset in the > method: > > Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free > space=1020k > Native frames: (J=compiled Jav

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v2]

2022-01-25 Thread Christian Hagedorn
On Tue, 25 Jan 2022 14:00:49 GMT, Erik Joelsson wrote: > Build changes look good. The reference to the new env variable is missing the > initial underscore in two places. Thanks Erik for reviewing the build changes. I updated the places. - PR: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v9]

2022-01-25 Thread Andrew Haley
On Tue, 25 Jan 2022 14:22:15 GMT, Alan Hayward wrote: >> Was this ever resolved? > > Sort of. That code has changed quite a bit - UseROPProtection now is a string > field not a bool. > "none" or not set - pac disabled. > "pac-ret" - pac always enabled > "standard" - pac enabled if the cpu+os sup

Withdrawn: 8274980: Improve adhoc build version strings

2022-01-25 Thread duke
On Thu, 28 Oct 2021 09:34:07 GMT, Magnus Ihse Bursie wrote: > Current adhoc version build strings are not ideal. Some of the problems: > * A build number of "0" is inserted, which make the version string look like > it's an official build, at least when not reading carefully > * The version st

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-01-25 Thread Andrew Haley
On Mon, 24 Jan 2022 15:56:06 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-25 Thread Yumin Qi
On Tue, 25 Jan 2022 10:29:48 GMT, Thomas Stuefe wrote: > I'm curious, under what circumstances would, before > https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the LoadLibrary > in imageDecompressor.cpp? Did this ever work? Was there ever a scenario where > the JVM was not involve

RFR: JDK-8279636: Update JCov version to 3.0.12

2022-01-25 Thread Alexandre Iline
JDK-8279636: Update JCov version to 3.0.12 - Commit messages: - JDK-8279636: Update JCov version to 3.0.12 Changes: https://git.openjdk.java.net/jdk/pull/7218/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7218&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-25 Thread Thomas Stuefe
On Tue, 25 Jan 2022 17:22:54 GMT, Yumin Qi wrote: >> I'm curious, under what circumstances would, before >> https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the >> LoadLibrary in imageDecompressor.cpp? Did this ever work? Was there ever a >> scenario where the JVM was not involved

RFR: JDK-8280583: Always build NMT

2022-01-25 Thread Thomas Stuefe
After discussing this on hotspot-runtime-dev [1], the general opinion seems to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT unconditional. This affects minimal builds only. As pointed out in the mail thread, the overhead is very small and it would get rid of one configur

Re: RFR: JDK-8280583: Always build NMT [v2]

2022-01-25 Thread Thomas Stuefe
> After discussing this on hotspot-runtime-dev [1], the general opinion seems > to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT > unconditional. This affects minimal builds only. As pointed out in the mail > thread, the overhead is very small and it would get rid of one

Re: RFR: JDK-8279636: Update JCov version to 3.0.12

2022-01-25 Thread Alan Bateman
On Wed, 26 Jan 2022 00:08:36 GMT, Alexandre Iline wrote: > JDK-8279636: Update JCov version to 3.0.12 Thanks, I can confirm that 3.0-12 works with the current main line. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7218