Re: RFR: JDK-8221762: Improve Main.gmk/FindTests.gmk bootstrap time

2019-04-01 Thread Tim Bell
Erik: With the new run-test test running framework, we introduced FindTests.gmk, which among other things, parses all the jtreg TEST.groups files to generate make targets for each group. While this is very nice, the current implementation in FindTests.gmk adds significant time to a simple "do

Re: RFR: JDK-8189861: Refactor CacheFind

2019-04-01 Thread Tim Bell
Erik: The macro CacheFind is a bit awkward to use with FillCacheFind. The naming is also not that great. This patch tries to improve this situation. The main difference is naming of the macros. Now the main entry point is "FindFiles". There are a couple of others as well, see MakeBase.gmk for

RFR: JDK-8189861: Refactor CacheFind

2019-04-01 Thread Erik Joelsson
The macro CacheFind is a bit awkward to use with FillCacheFind. The naming is also not that great. This patch tries to improve this situation. The main difference is naming of the macros. Now the main entry point is "FindFiles". There are a couple of others as well, see MakeBase.gmk for

RFR: JDK-8221762: Improve Main.gmk/FindTests.gmk bootstrap time

2019-04-01 Thread Erik Joelsson
With the new run-test test running framework, we introduced FindTests.gmk, which among other things, parses all the jtreg TEST.groups files to generate make targets for each group. While this is very nice, the current implementation in FindTests.gmk adds significant time to a simple "do

RFR: JDK-8221764: Reduce make Init.gmk logging overhead

2019-04-01 Thread Erik Joelsson
The Init.gmk and InitSupport.gmk makefiles provide the foundational framework for bootstrapping the build. That bootstrap process has grown over time and is starting to take significant time to execute on Windows. One reason for this is that every extra command executed at this level gets the

Re: build number for a jdk-*-ga tag?

2019-04-01 Thread Erik Joelsson
Hello Matthias, Looking at the tags in the repo, jdk-12-ga points to the same change as jdk-12+33, so that would be the build number we released. If you download the binaries from http://jdk.java.net/12/, the version string reported from those builds also say 33: $ bin/java -version openjdk

Re: [13] 8221731: Fix doclint handling of accessibility heading in java.desktop

2019-04-01 Thread Erik Joelsson
Looks good. /Erik On 2019-03-31 23:45, Prasanta Sadhukhan wrote: Hi All, With the fix of JDK-8220250 fix headings in java.desktop the doclint handling can add back the accessibility check in the makefile. diff -r 901ff5aba330

build number for a jdk-*-ga tag?

2019-04-01 Thread Matthias Klose
When preparing packages for Debian/Ubuntu for openjdk-12, I was using versions derived from the jdk-12+ tags (e.g. 12~31, 12~32, ...). Using the tilde meaning "less than/earlier than 12). What build number should a build from the jdk-12-ga get? Asking because my packaging choose to set the

[13] 8221731: Fix doclint handling of accessibility heading in java.desktop

2019-04-01 Thread Prasanta Sadhukhan
Hi All, With the fix of JDK-8220250 fix headings in java.desktop the doclint handling can add back the accessibility check in the makefile. diff -r 901ff5aba330 make/CompileJavaModules.gmk --- a/make/CompileJavaModules.gmk    Sun Mar 31