Re: RFR: JDK-8231467: Missing make prerequisite declaration corrupts make dependency files on Windows

2019-09-25 Thread Tim Bell
Erik: Looks good to me as well. Tim On 2019-09-25 11:59, Magnus Ihse Bursie wrote: Looks good to me. /Magnus 25 sep. 2019 kl. 19:59 skrev Erik Joelsson : In JDK-8217728 I introduced a new rule in SetupNativeCompilation which combines all the generated *.d dependency files into one for

Re: RFR: JDK-8231467: Missing make prerequisite declaration corrupts make dependency files on Windows

2019-09-25 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 25 sep. 2019 kl. 19:59 skrev Erik Joelsson : > > In JDK-8217728 I introduced a new rule in SetupNativeCompilation which > combines all the generated *.d dependency files into one for each link > target. This combining currently depends on all the object files

RFR: JDK-8231467: Missing make prerequisite declaration corrupts make dependency files on Windows

2019-09-25 Thread Erik Joelsson
In JDK-8217728 I introduced a new rule in SetupNativeCompilation which combines all the generated *.d dependency files into one for each link target. This combining currently depends on all the object files being compiled first. On Windows, we sometimes also create a resource file, which also