RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Julia Boes
This change implements a simple web server that can be run on the command-line with `java -m jdk.httpserver`. This is facilitated by adding an entry point for the `jdk.httpserver` module, an implementation class whose main method is run when the above command is executed. This is the first such

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Julia Boes
On Tue, 14 Sep 2021 15:42:06 GMT, Jaikiran Pai wrote: >> src/java.base/windows/classes/sun/net/www/content-types.properties line 30: >> >>> 28: application/octet-stream: \ >>> 29: description=Generic Binary Stream;\ >>> 30: file_extensions=.saveme,.dump,.hqx,.arc,.obj,.lib,.bin,.

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Julia Boes
On Tue, 14 Sep 2021 13:47:48 GMT, Andrey Turbanov wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose mai

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 13:38:27 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line >> 106: >> >>> 104: var h = headers.entrySet().stream() >>> 105: .collect(Collectors.toUnmodifiableMap( >>> 106: Ent

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 16:45:08 GMT, Daniel Fuchs wrote: >> Just a rewording, maybe. > > Hmm... Maye that should be "The response headers *are sent*". The non-obvious > technical details is that the response headers are sent before the body - as > soon as you call `sendResponseHeaders`. The link

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Wed, 15 Sep 2021 07:49:38 GMT, Michael McMahon wrote: >> Or maybe - which would be more accurate: >> >> >> with the given {@code statusCode} and the body bytes' length (or {@code -1} >> if the body is empty). > > I agree with your second suggestion. It's better not to refer to the > 'Conte

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-15 Thread Julia Boes
On Tue, 14 Sep 2021 15:56:28 GMT, Jim Laskey wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main meth

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v2]

2021-09-15 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request incrementally with three additional commits since the last revision: - small spec rewording - add module main class to symbolgen

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v2]

2021-09-15 Thread Julia Boes
On Wed, 15 Sep 2021 03:14:04 GMT, Jaikiran Pai wrote: >> FWIW `.z` is the extension of the old Unix `compress` program. > >> FWIW `.z` is the extension of the old Unix `compress` program. > > Thank you Florent, I wasn't aware of that. related PR for reference: https://github.com/openjdk/jdk/pul

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-16 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: correct path handling - Changes: - all: https://git.openjd

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> correct path handling > > src/jdk.httpserver/share/classes/modu

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an i

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an i

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v4]

2021-09-20 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - Merge branch 'master' into simpleserve

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-21 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge branch 'master' into simpleserv

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v4]

2021-09-21 Thread Julia Boes
On Mon, 20 Sep 2021 16:16:10 GMT, Daniel Fuchs wrote: >> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java >> line 340: >> >>> 338: } >>> 339: } >>> 340: return false; >> >> This will start checking from the root of

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-21 Thread Julia Boes
On Tue, 21 Sep 2021 16:18:54 GMT, Daniel Fuchs wrote: >> The problem I was referring to was not about printing to the console. I >> hadn't thought about that, I agree the default locale should be used there. >> I was referring to `Last-modified` HTTP headers with a non-English date >> value, e

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 15:23:33 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >>

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >>

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 17:16:08 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >>

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request incrementally with two additional commits since the last revision: - change default bind address from anylocal to loopback - address PR com

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Julia Boes
On Fri, 17 Sep 2021 14:11:38 GMT, Julia Boes wrote: > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > This being said, I want to make sure we're taking the right decisio

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v7]

2021-09-28 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: - use ipv4/ipv6 specific loopback address and add a

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v7]

2021-09-28 Thread Julia Boes
On Tue, 28 Sep 2021 10:08:29 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an i

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-29 Thread Julia Boes
On Tue, 28 Sep 2021 10:30:21 GMT, Bernd Eckenfels wrote: > * For all interfaces use "-b 0.0.0.0" (IPv4) or "-b ::" (IPv6) > > Instead of: > > * For 0.0.0.0 (all interfaces) use -b 0.0.0.0 or -b ::0 > > In the usage? > > (I think ?::? is canon?) Good point, "::" is recommended, e.g. in RFC59

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v8]

2021-09-29 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: update output for all interfaces - Changes: - all: htt

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v9]

2021-10-12 Thread Julia Boes
nally, a small API is introduced for programmatic creation and > customization. > > Testing: tier1-3. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Minor rewording of bind address output - Mer

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v9]

2021-10-18 Thread Julia Boes
On Mon, 18 Oct 2021 11:38:22 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 24 commits: >> >> - Minor rewording of bind address output >> - Merge bra

Integrated: 8245095: Implementation of JEP 408: Simple Web Server

2021-10-19 Thread Julia Boes
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class wh

RFR: 8277460: Add jwebserver tool

2021-11-24 Thread Julia Boes
This change introduces jwebserver, a dedicated JDK tool for the Simple Web Server. A description is provided in a follow-up comment. - Commit messages: - update module summary - Merge branch 'master' into jwebserver - add version option, consolidate tests, update module and pack

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Julia Boes
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote: > This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. This change adds a dedicated command-line tool for the Simple Web Server, to improve

Re: RFR: 8277459: Add jwebserver tool

2021-11-24 Thread Julia Boes
On Wed, 24 Nov 2021 11:57:16 GMT, Daniel Fuchs wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java > line 110:

Re: RFR: 8277459: Add jwebserver tool [v2]

2021-11-24 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comments: * updat

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-24 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: fix whitespace error, add miss

RFR: 8277847: Support toolGuide tag in class-level documentation

2021-11-25 Thread Julia Boes
This change adds support for the `@toolGuide` tag in class-level API documentation. (A use case is the jwebserver tool, where the com.sun.net.httpserver.SimpleFileServer class provides API points for extension and customization of the underlying server and its components. Linking to the tool'

Re: RFR: 8277847: Support toolGuide tag in class-level documentation

2021-11-26 Thread Julia Boes
On Fri, 26 Nov 2021 11:43:25 GMT, Daniel Fuchs wrote: >> This change adds support for the `@toolGuide` tag in class-level API >> documentation. >> >> (A use case is the jwebserver tool, where the >> com.sun.net.httpserver.SimpleFileServer class provides API points for >> extension and custom

Integrated: 8277847: Support toolGuide tag in class-level documentation

2021-11-29 Thread Julia Boes
On Thu, 25 Nov 2021 15:58:58 GMT, Julia Boes wrote: > This change adds support for the `@toolGuide` tag in class-level API > documentation. > > (A use case is the jwebserver tool, where the > com.sun.net.httpserver.SimpleFileServer class provides API points for > extension

Re: RFR: 8277459: Add jwebserver tool [v4]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - a

Re: RFR: 8277459: Add jwebserver tool [v4]

2021-11-29 Thread Julia Boes
On Wed, 24 Nov 2021 14:05:03 GMT, Julia Boes wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java >> line 110: >> >>> 108: * >>> 109: * A simple HTTP file server implementation is provided via the >>> 110

Re: RFR: 8277459: Add jwebserver tool [v5]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: update comment abo

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-29 Thread Julia Boes
On Thu, 25 Nov 2021 10:09:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix whitespace error, add missing code tag > > src/jdk.httpserver/share/classes/s

Re: RFR: 8277459: Add jwebserver tool [v6]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: -

Integrated: 8277459: Add jwebserver tool

2021-12-01 Thread Julia Boes
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes wrote: > This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. This pull request has now been integrated. Changeset: f505396c Author: Jul

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview)

2022-03-21 Thread Julia Boes
On Mon, 21 Mar 2022 10:45:27 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.jav