Withdrawn: 8288001: SOURCE_DATE_EPOCH should not be set by default

2022-06-20 Thread KIRIYAMA Takuya
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote: > At default configuration, SOURCE_DATE_EPOCH is exported as environment > variable in SetupReproducibleBuild. Then, gcc is affected of > SOURCE_DATE_EPOCH environment variable. This value is used only to set > SOURCE_DATE_ISO_8601 (excep

Re: RFR: 8288001: SOURCE_DATE_EPOCH should not be set by default

2022-06-20 Thread KIRIYAMA Takuya
On Tue, 14 Jun 2022 09:50:57 GMT, Magnus Ihse Bursie wrote: >> Thank you for your comments. >> I understood the goal of reproducible build. But now, >> ENABLE_REPRODUCIBLE_BUILD is set to false in default configuration. >> Then I think minimize the effort of SOURCE_DATE_EPOCH when reproducible

Integrated: Merge jdk19

2022-06-20 Thread Jesper Wilhelmsson
On Mon, 20 Jun 2022 18:20:21 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 7039c661 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/7039c6616ad1b67320f08e7ea4763e8ff4977430 Stats: 752 lines

Re: RFR: Merge jdk19 [v2]

2022-06-20 Thread Jesper Wilhelmsson
> Forwardport JDK 19 -> JDK 20 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 96 additional commits since the last revision: - Me

RFR: Merge jdk19

2022-06-20 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge - 8288527: broken link in java.base/java/util/zip/package-summary.html - 8288741: JFR: Change package name of snippet files - 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state - 8287800: J

RFR: JDK-8288740: Change incorrect documentation for sjavac flag

2022-06-20 Thread Julian Waters
The documentation for build performance currently points to the non-existent --enable-sjavac flag to enable sjavac, the correct one is actually --enable-javac-server (Finally seem to have gotten pandoc working, hopefully the html is correct this time) - Commit messages: - Correct

Re: RFR: 8286623: Bundle zlib by default with JDK on macos aarch64

2022-06-20 Thread Jaikiran Pai
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote: > Can I please get a review of this change to the build system which now makes > bundled zlib as the default for macos aarch64 systems? > > We have been running into various intermittent failures on macos aarch64 > systems for several mont

Re: assembler_x86.cpp:11128:38: error: 'this' pointer is null

2022-06-20 Thread Aleksey Shipilev
On 6/16/22 20:00, Browser wrote: ... It did result in a runable `./build/linux-x86_64-server-release/images/jdk/bin/java` / JDK, however I no longer have confidence in the JDK generated. null pointers make me nervous, use-after-free warnings also make me nervous! Is this something I need to worr

Re: assembler_x86.cpp:11128:38: error: 'this' pointer is null

2022-06-20 Thread Aleksey Shipilev
On 6/17/22 09:36, Andrew Haley wrote: On 6/16/22 19:00, Browser wrote: > That one I'll chalk up to not-yet-resolved issue with GCC 12. Mainline does not seem to fail GCC 12 > the same way, but it does fail too. > sh...@redhat.com: >> Pleasing the newer compiler version is always someth